search

openshift / oadp-operator

OADP Operator
Apache License 2.0
77 stars 70 forks source link

[OADP-1.4] Bump up CirrOS image size for PSI #1500

Closed weshayutin closed 3 weeks ago

weshayutin commented 1 month ago

Why the changes were made Importing the CirrOS image into a cluster on OpenStack (storage class ocs-storagecluster-ceph-rbd-virtualization) fails with Virtual image size 117440512 is larger than the reported available storage 117317632. A larger PVC is required.

I'm not sure why this is the case, but bumping it up from 128M to 150 works.

How to test the changes made E2E tests are not set up to run against OpenStack just yet, but hacking it up to do nothing but download the CirrOS image reproduces the bug and the fix. You can also create the Data Volume manually:

apiVersion: cdi.kubevirt.io/v1beta1 kind: DataVolume metadata: name: cirros namespace: openshift-virtualization-os-images spec: pvc: accessModes:

weshayutin commented 1 month ago

@mrnold FYI

mrnold commented 1 month ago

Oh right, the immediate-mode tests were already merged into 1.4. So the size change also needs to go into tests/e2e/sample-applications/virtual-machines/cirros-test/cirros-test-immediate.yaml

mpryc commented 1 month ago

/retest

mpryc commented 1 month ago

/lgtm

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD a924ad9e837ccd8186aff142b694ef562553d012 and 2 for PR HEAD 30747aed204e1ccd92a9d29bde70b25201791889 in total

mrnold commented 1 month ago

Can you pull this in? https://github.com/weshayutin/oadp-operator/pull/19

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD a924ad9e837ccd8186aff142b694ef562553d012 and 2 for PR HEAD 30747aed204e1ccd92a9d29bde70b25201791889 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD a924ad9e837ccd8186aff142b694ef562553d012 and 2 for PR HEAD 30747aed204e1ccd92a9d29bde70b25201791889 in total

mateusoliveira43 commented 1 month ago

/hold PR needs changes @mrnold pointed out

weshayutin commented 3 weeks ago

/retest

openshift-ci[bot] commented 3 weeks ago

New changes are detected. LGTM label has been removed.

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrnold, weshayutin Once this PR has been reviewed and has the lgtm label, please assign shawn-hurley for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/oadp-operator/blob/oadp-1.4/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mrnold, weshayutin Once this PR has been reviewed and has the lgtm label, please assign shawn-hurley for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/oadp-operator/blob/oadp-1.4/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment