search

openshift / oadp-operator

OADP Operator
Apache License 2.0
78 stars 72 forks source link

OADP Operator update for aug-22-2024 velero rebase #1502

Closed shubham-pampattiwar closed 2 months ago

shubham-pampattiwar commented 2 months ago

Why the changes were made

Go mod and CRD updates required due to Velero rebase

How to test the changes made

Any kind of E2E sanity testing would be helpful here !

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD b0e0d121d272c0bcbe75dcb4008fe7cb7bb13904 and 2 for PR HEAD 9c58efdd7564d41add6b0b9f67d29520959462a8 in total

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD b0e0d121d272c0bcbe75dcb4008fe7cb7bb13904 and 2 for PR HEAD 9c58efdd7564d41add6b0b9f67d29520959462a8 in total

mateusoliveira43 commented 2 months ago

I think this needs to be updated https://github.com/openshift/oadp-operator/blob/master/tests/e2e/virt_backup_restore_suite_test.go#L245

after rebase, should not error anymore, right?

kaovilai commented 2 months ago

unless there's merge conflict, rebasing should not be necessary. retest should test against new base ref merged with pr.

kaovilai commented 2 months ago

I think this needs to be updated https://github.com/openshift/oadp-operator/blob/master/tests/e2e/virt_backup_restore_suite_test.go#L245

ya agree. seems to be successful now.. if expected, need to remove this RestoreErr

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD b0e0d121d272c0bcbe75dcb4008fe7cb7bb13904 and 2 for PR HEAD 9c58efdd7564d41add6b0b9f67d29520959462a8 in total

weshayutin commented 2 months ago

/retest

shubham-pampattiwar commented 2 months ago

/retest

shubham-pampattiwar commented 2 months ago

/test 4.14-e2e-test-aws

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oadp-operator/blob/master/OWNERS)~~ [kaovilai,mateusoliveira43,shubham-pampattiwar,sseago] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@shubham-pampattiwar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).