search

openshift / oadp-operator

OADP Operator
Apache License 2.0
77 stars 70 forks source link

[OADP-1.4] Bump up CirrOS image size for PSI #1510

Closed weshayutin closed 3 weeks ago

weshayutin commented 3 weeks ago

Why the changes were made Importing the CirrOS image into a cluster on OpenStack (storage class ocs-storagecluster-ceph-rbd-virtualization) fails with Virtual image size 117440512 is larger than the reported available storage 117317632. A larger PVC is required.

I'm not sure why this is the case, but bumping it up from 128M to 150 works.

How to test the changes made E2E tests are not set up to run against OpenStack just yet, but hacking it up to do nothing but download the CirrOS image reproduces the bug and the fix. You can also create the Data Volume manually:

bah: replaces https://github.com/openshift/oadp-operator/pull/1500

mrnold commented 3 weeks ago

Please also add the size increase to tests/e2e/sample-applications/virtual-machines/cirros-test/cirros-test-immediate.yaml, or the tests will fail again.

weshayutin commented 3 weeks ago

Please also add the size increase to tests/e2e/sample-applications/virtual-machines/cirros-test/cirros-test-immediate.yaml, or the tests will fail again.

ah thank you @mrnold

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mrnold, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[tests/e2e/OWNERS](https://github.com/openshift/oadp-operator/blob/oadp-1.4/tests/e2e/OWNERS)~~ [kaovilai,shubham-pampattiwar,weshayutin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kaovilai commented 3 weeks ago

/lgtm /retest

openshift-ci[bot] commented 3 weeks ago

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).