search

openshift / oadp-operator

OADP Operator
Apache License 2.0
77 stars 70 forks source link

OADP-4819: Add OKE as valid-subscription #1514

Closed rayfordj closed 2 weeks ago

rayfordj commented 2 weeks ago

https://issues.redhat.com/browse/OADP-4819

openshift-ci-robot commented 2 weeks ago

@rayfordj: This pull request references OADP-4819 which is a valid jira issue.

In response to [this](https://github.com/openshift/oadp-operator/pull/1514): >https://issues.redhat.com/browse/OADP-4819 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foadp-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD ca3750b2146d91b0bc0008d4ae943f565cf7c148 and 2 for PR HEAD ec44811e2e1c5da6a112ea75ec487c548190dfbc in total

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rayfordj, shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oadp-operator/blob/oadp-1.3/OWNERS)~~ [rayfordj,shubham-pampattiwar,sseago] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD ca3750b2146d91b0bc0008d4ae943f565cf7c148 and 2 for PR HEAD ec44811e2e1c5da6a112ea75ec487c548190dfbc in total

weshayutin commented 2 weeks ago

/retest

mateusoliveira43 commented 2 weeks ago

Need to do changes in PROW for this to pass, because of ARM. My bad

Is this urgent?

rayfordj commented 2 weeks ago

Need to do changes in PROW for this to pass, because of ARM. My bad

Is this urgent?

At the moment, no, 1.3 is not urgent. It is, I believe, mid-November planned, so we have time here.

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD ca3750b2146d91b0bc0008d4ae943f565cf7c148 and 2 for PR HEAD ec44811e2e1c5da6a112ea75ec487c548190dfbc in total

mateusoliveira43 commented 2 weeks ago

@rayfordj alright

once I have time I create a PR in PROW to fix this and unblock us

mateusoliveira43 commented 2 weeks ago

to unblock this PR https://github.com/openshift/release/pull/56496

rayfordj commented 2 weeks ago

/retest-required

openshift-ci[bot] commented 2 weeks ago

@rayfordj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).