search

openshift / oadp-operator

OADP Operator
Apache License 2.0
78 stars 72 forks source link

OADP-4803: Block OCP upgrade to v4.16 #1518

Closed rayfordj closed 2 months ago

rayfordj commented 2 months ago

https://issues.redhat.com/browse/OADP-4803

Use olm.maxOpenShiftVersion to prevent upgrading to OCP v4.16 when OADP 1.3 is installed. OADP 1.3 on OCP v4.15 should upgrade to OADP 1.4 prior to upgrading to OCP v4.16.

openshift-ci-robot commented 2 months ago

@rayfordj: This pull request references OADP-4803 which is a valid jira issue.

In response to [this](https://github.com/openshift/oadp-operator/pull/1518): >https://issues.redhat.com/browse/OADP-4803 > >Use `olm.maxOpenShiftVersion` to prevent upgrading to OCP v4.16 when OADP 1.3 is installed. OADP 1.3 on OCP v4.15 should upgrade to OADP 1.4 prior to upgrading to OCP v4.16. > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foadp-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
shubham-pampattiwar commented 2 months ago

I thought we were not gonna block OCP upgrades ?

rayfordj commented 2 months ago

I thought we were not gonna block OCP upgrades ?

It was under consideration and the decision has been made to proceed with preventing it if 1.3 is installed.

shawn-hurley commented 2 months ago

Is there a way for a user to force the upgrade if this is set?

rayfordj commented 2 months ago

Is there a way for a user to force the upgrade if this is set?

From the docs beginning with 4.8 (when introduced) to as recent as 4.16: image

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rayfordj, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oadp-operator/blob/oadp-1.3/OWNERS)~~ [rayfordj,shubham-pampattiwar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
weshayutin commented 2 months ago

Is there a way for a user to force the upgrade if this is set?

@shawn-hurley so a cluster admin can nuke/uninstall oadp if they want to click through.
Once the cluster is upgraded they can install again w/ the same dpa and creds and everything comes back as is. No required dpa changes from 1.3 -> 1.4

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 14725052b929e461e3149e68cf43356ec703cf41 and 2 for PR HEAD 823d3f81ce5fa5d54e1ae79443d4ad2eeb02c984 in total

rayfordj commented 2 months ago

/retest-required

openshift-ci[bot] commented 2 months ago

@rayfordj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).