search

openshift / oadp-operator

OADP Operator
Apache License 2.0
77 stars 70 forks source link

Add support for VSL name and labels #1523

Closed stillalearner closed 1 week ago

stillalearner commented 1 week ago

Why the changes were made

Added VSL name and labels, similar to BSL, so it is easier to remove the unwanted VSLs when DPA is edited.

Context: Issue #1469

stillalearner commented 1 week ago

/retest

mrnold commented 1 week ago

/test 4.14-e2e-test-aws

openshift-ci[bot] commented 1 week ago

@stillalearner: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, stillalearner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oadp-operator/blob/master/OWNERS)~~ [kaovilai,shubham-pampattiwar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shubham-pampattiwar commented 1 week ago

/lgtm