openshift / oadp-operator

OADP Operator
Apache License 2.0
78 stars 72 forks source link

OADP-3562: Fix controller panic on secret key-value parsing #1529

Closed stillalearner closed 1 month ago

stillalearner commented 1 month ago

Fixes -> https://issues.redhat.com/browse/OADP-3562

Tested successfully with empty value for key.

status: conditions:

openshift-ci-robot commented 1 month ago

@stillalearner: This pull request references OADP-3562 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/oadp-operator/pull/1529): >Fixes -> https://issues.redhat.com/browse/OADP-3562 > >Tested successfully with empty value for key. > >status: > conditions: > - lastTransitionTime: "2024-09-24T09:04:15Z" > message: secret parsing error in key AZURE_STORAGE_ACCOUNT_ACCESS_KEY > reason: Error > status: "False" > type: Reconciled > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foadp-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
kaovilai commented 1 month ago

/hold for CI fix

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar, stillalearner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oadp-operator/blob/master/OWNERS)~~ [kaovilai,mateusoliveira43,shubham-pampattiwar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mateusoliveira43 commented 1 month ago

/unhold E2E tests are working again

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD ce8546dce4d513c06c53ce4841881561cd18d974 and 2 for PR HEAD 8d9f5f5810d79f2f7f6d436bf6d95e20c0d4d910 in total

openshift-ci[bot] commented 1 month ago

@stillalearner: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).