search

openshift / oadp-operator

OADP Operator
Apache License 2.0
78 stars 72 forks source link

fix: Update NAC CRDs #1532

Closed mateusoliveira43 closed 1 month ago

mateusoliveira43 commented 1 month ago

Why the changes were made

Unblock developer NAC testing in cluster.

How to test the changes made

Run make deploy-olm and check if NAC is working properly.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oadp-operator/blob/master/OWNERS)~~ [kaovilai,mateusoliveira43,shubham-pampattiwar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 94bc5ae81e15c97b605ce416421782a12b672327 and 2 for PR HEAD 6d78fdb13b34d4bb239d2d10c64d684103d309b9 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD ce8546dce4d513c06c53ce4841881561cd18d974 and 1 for PR HEAD 6d78fdb13b34d4bb239d2d10c64d684103d309b9 in total

mpryc commented 1 month ago

/test 4.14-e2e-test-aws

mpryc commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

@mateusoliveira43: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).