search

openshift / oadp-operator

OADP Operator
Apache License 2.0
78 stars 72 forks source link

fix: Velero server args organization #1535

Closed mateusoliveira43 closed 1 month ago

mateusoliveira43 commented 1 month ago

Why the changes were made

I think it is easier to read the code if all YAML definitions logic are in api/v1alpha1 folder.

How to test the changes made

Check that output of make bundle was not changed by these changes.

shubham-pampattiwar commented 1 month ago

cc @kaovilai

kaovilai commented 1 month ago

timeout

/retest

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oadp-operator/blob/master/OWNERS)~~ [kaovilai,mateusoliveira43,shubham-pampattiwar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kaovilai commented 1 month ago

/lgtm

shubham-pampattiwar commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@mateusoliveira43: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).