search

openshift / oadp-operator

OADP Operator
Apache License 2.0
77 stars 71 forks source link

OADP-732: Enable ability to use private registry for custom plugins (add image pull secrets) #739

Open PendaGTP opened 2 years ago

PendaGTP commented 2 years ago

Is your feature request related to a problem? Please describe. I want to use a custom plugins, the image of it is located on a private container registry. It is not possible to add an imagePullSecret to the Velero deployment.

Describe the solution you'd like Allow to set the imagePullSecrets property.

Describe alternatives you've considered If the configuration of the imagePullSecrets property is not possible, it could be nice to indicate to the controller to ignore the modifications of this property, this one could be modified by a mutation at admission. This is probably not the best idea, I'm not very inspired.

kaovilai commented 2 years ago

Sounds like your use case should already be covered by steps to create Secret outlined in this doc. https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/

You should not have to modify velero deployment for this to work.

Reopen if this doesn't resolve your issue.

PendaGTP commented 2 years ago

@kaovilai, yes I can create a secret that contains the information needed to authenticate to the private registry but how do I tell to OADP Operator to use this secret (and thus add the secret to imagePullSecret of the Velero deployment)? If I modify the deployment of Velero, the operator undo my modifications, which I understand.

Without this possibility, I don't see how to use a custom plugin which is located on a private registry (https://github.com/openshift/oadp-operator/blob/master/docs/config/plugins.md).

kaovilai commented 2 years ago

Ok thanks. Reading it again this is a feature we have to implement.

kaovilai commented 2 years ago

Tracked in https://issues.redhat.com/browse/OADP-732

openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 1 year ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 1 year ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 1 year ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/oadp-operator/issues/739#issuecomment-1474766046): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kaovilai commented 6 months ago

/lifecycle frozen