search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
263 stars 138 forks source link

fix review/user validation URLs #100

Closed stlaz closed 5 years ago

stlaz commented 5 years ago

These URLs were previously built from login URL if they were not specifically set by the user. In 4.0, the OAuth server gets separated from the API server and therefore these endpoints would be by default set improperly.

If an OAuth server different from the integrated one was set for the OAuth flows, this could be broken even in earlier versions of OpenShift.

openshift-merge-robot commented 5 years ago

/retest

stlaz commented 5 years ago

Comments addressed.

openshift-merge-robot commented 5 years ago

/retest

mrogers950 commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, mrogers950, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)~~ [enj,mrogers950] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment