search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
263 stars 138 forks source link

openshift provider: refetch oauth endpoints on login #101

Closed stlaz closed 5 years ago

stlaz commented 5 years ago

Adds refetching of oauth endpoints and endpoints based on them when a user tries to do a login. This happens unless these are hardcoded by user config when the binary is started.

The provider will try to refetch the information also in the cases where the fetching during login originally failed, but the endpoint information is required for whatever different purpose.

The number of refetched endpoints URLs will reduced when https://github.com/openshift/oauth-proxy/pull/100 is merged.

cc @openshift/sig-auth

openshift-merge-robot commented 5 years ago

/retest

stlaz commented 5 years ago

This is broken because the Get*() methods of the default provider instead of the methods of OpenShift provider are used while getting redirect URL. Either I made a mistake somewhere or overestimated the way Go works with its "objects".

stlaz commented 5 years ago

The latter seems to be true.

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericavonb, mrogers950, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)~~ [ericavonb,mrogers950] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest