search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
263 stars 138 forks source link

providers: don't cache login and redeem URLs #102

Closed stlaz closed 5 years ago

stlaz commented 5 years ago

The code which was caching login and redeem URLs is actually working in parallel which may cause nil dereferences as the cache is being wiped out. Don't cache these urls at all.

mrogers950 commented 5 years ago

Just the two pending comments and this looks OK to me.

stlaz commented 5 years ago

Thanks, both the comments should be addressed.

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

mrogers950 commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrogers950, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)~~ [mrogers950] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

ericavonb commented 5 years ago

/retest

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest

stlaz commented 5 years ago

/retest