search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
263 stars 138 forks source link

honor KUBERNETES_SERVICE_PORT #121

Closed jcantrill closed 4 years ago

jcantrill commented 5 years ago

This PR makes the provider honor the KUBERNETES_SERVICE_PORT var

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcantrill To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: ericavonb

If they are not already assigned, you can assign the PR to them by writing /assign @ericavonb in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enj commented 5 years ago

go fmt please

openshift-ci-robot commented 5 years ago

@jcantrill: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws c6a0facd11ea64e41f34a8b1bceaa79db9d95715 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
enj commented 5 years ago

Still needs go fmt from what I can see:

image

enj commented 5 years ago

/uncc

@stlaz @sttts @mfojtik

jcantrill commented 4 years ago

@mfojtik ping

sttts commented 4 years ago

Why is this need?

sttts commented 4 years ago

/close

until we have a reason to change it.

openshift-ci-robot commented 4 years ago

@sttts: Closed this PR.

In response to [this](https://github.com/openshift/oauth-proxy/pull/121#issuecomment-621269939): >/close > >until we have a reason to change it. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.