search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
263 stars 138 forks source link

Clarify versioning #128

Closed jpkrohling closed 3 years ago

jpkrohling commented 5 years ago

As per this repo's documentation and examples, the openshift/oauth-proxy:latest image:tag is being used. But what are the expectations for production usage? Is there a version for each OpenShift version? Or should we expect that latest is supported by the two most recent OpenShift releases?

jpkrohling commented 5 years ago

I talked with @stlaz via IRC, and latest is indeed appropriate, supported in the last two OpenShift releases.

jpkrohling commented 5 years ago

It seems the answer isn't that clear. While the last two OpenShift releases might work, the actual supported version depends on the underlying cluster version. For OpenShift 4.2, an image that works on that version is made available.

I'm reopening, as it's not clear to me what's the policy around the supported version that should be used.

Ideally, my deployment wouldn't care about it: perhaps I could just annotate my deployment and an OpenShift OAuth Operator would inject the proxy as a sidecar?

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 4 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/oauth-proxy/issues/128#issuecomment-727260760): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.