Closed JustinKuli closed 3 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: JustinKuli
To complete the pull request process, please assign deads2k
You can assign the PR to them by writing /assign @deads2k
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Hi @JustinKuli. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/assign @deads2k
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen
.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Exclude this issue from closing again by commenting /lifecycle frozen
.
/close
@openshift-bot: Closed this PR.
We ran into the problem we think is described in https://github.com/openshift/oauth-proxy/issues/73, and found this as a workaround.
If the default ingress certificate is changed in the cluster, then the OpenShift OAuth server certificate might no longer be trusted by default. However, assuming the certificate was changed with this procedure (link), then OpenShift will add the new certificate to a bundle which we can mount into the container (more info on that process here (link).
This PR adds a section describing this configuration in the README, and adds it to the example sidecar configuration.