search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
261 stars 137 forks source link

[release-4.6] Bug 1915667: remove logging when authz header is present but basic auth is not attempted #200

Closed openshift-cherrypick-robot closed 3 years ago

openshift-cherrypick-robot commented 3 years ago

This is an automated cherry-pick of #197

/assign stlaz

openshift-ci-robot commented 3 years ago

@openshift-cherrypick-robot: Bugzilla bug 1879878 has been cloned as Bugzilla bug 1915667. Retitling PR to link against new bug. /retitle [release-4.6] Bug 1915667: remove logging when authz header is present but basic auth is not attempted

In response to [this](https://github.com/openshift/oauth-proxy/pull/200): >[release-4.6] Bug 1879878: remove logging when authz header is present but basic auth is not attempted Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 years ago

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1915667, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.6.z) matches configured target release for branch (4.6.z) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST) * dependent bug [Bugzilla bug 1879878](https://bugzilla.redhat.com/show_bug.cgi?id=1879878) is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA)) * dependent [Bugzilla bug 1879878](https://bugzilla.redhat.com/show_bug.cgi?id=1879878) targets the "4.7.0" release, which is one of the valid target releases: 4.7.0 * bug has dependents
In response to [this](https://github.com/openshift/oauth-proxy/pull/200): >[release-4.6] Bug 1915667: remove logging when authz header is present but basic auth is not attempted Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stlaz commented 3 years ago

/lgtm

barleyer commented 3 years ago

/bugzilla cc-qa

openshift-ci-robot commented 3 years ago

@barleyer: This pull request references Bugzilla bug 1915667, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.6.z) matches configured target release for branch (4.6.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST) * dependent bug [Bugzilla bug 1879878](https://bugzilla.redhat.com/show_bug.cgi?id=1879878) is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA)) * dependent [Bugzilla bug 1879878](https://bugzilla.redhat.com/show_bug.cgi?id=1879878) targets the "4.7.0" release, which is one of the valid target releases: 4.7.0 * bug has dependents

Requesting review from QA contact: /cc @barleyer

In response to [this](https://github.com/openshift/oauth-proxy/pull/200#issuecomment-759964264): >/bugzilla cc-qa Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
barleyer commented 3 years ago

I'm following JIRA issue DPTP-660 to do the pre-merge verification. The bug is pre-merge verified in 1915667#c1. So per JIRA issue DPTP-660's Description process, adding QE lgtm: /lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barleyer, openshift-cherrypick-robot, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/release-4.6/OWNERS)~~ [stlaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
barleyer commented 3 years ago

/label qe-approved

openshift-ci-robot commented 3 years ago

@barleyer: The label(s) qe-approved cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/openshift/oauth-proxy/pull/200#issuecomment-765226859): >/label qe-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stlaz commented 3 years ago

/bugzilla refresh

openshift-ci-robot commented 3 years ago

@stlaz: This pull request references Bugzilla bug 1915667, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.6.z) matches configured target release for branch (4.6.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST) * dependent bug [Bugzilla bug 1879878](https://bugzilla.redhat.com/show_bug.cgi?id=1879878) is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA)) * dependent [Bugzilla bug 1879878](https://bugzilla.redhat.com/show_bug.cgi?id=1879878) targets the "4.7.0" release, which is one of the valid target releases: 4.7.0 * bug has dependents
In response to [this](https://github.com/openshift/oauth-proxy/pull/200#issuecomment-773959574): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 years ago

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1915667 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oauth-proxy/pull/200): >[release-4.6] Bug 1915667: remove logging when authz header is present but basic auth is not attempted Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.