search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
261 stars 137 forks source link

Bug 1958158: providers/openshift: remove logging of authorizer decisions #214

Closed s-urbaniak closed 3 years ago

s-urbaniak commented 3 years ago

This prevents log flooding of anomoys requests with no bearer token. This also prevents logging of empty authorizer denial reasons with an initial request against oauth-proxy before it redirects to the login page.

/cc @standa @sttts

openshift-ci[bot] commented 3 years ago

@s-urbaniak: GitHub didn't allow me to request PR reviews from the following users: standa.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/oauth-proxy/pull/214): >This prevents log flooding of anomoys requests with no bearer token. This also prevents logging of empty authorizer denial reasons with an initial request against oauth-proxy before it redirects to the login page. > >/cc @standa @sttts Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 years ago

@s-urbaniak: This pull request references Bugzilla bug 1958158, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.8.0) matches configured target release for branch (4.8.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @barleyer

In response to [this](https://github.com/openshift/oauth-proxy/pull/214): >Bug 1958158: providers/openshift: remove logging of authorizer decisions Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stlaz commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)~~ [stlaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
s-urbaniak commented 3 years ago

/test e2e-component

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci[bot] commented 3 years ago

@s-urbaniak: All pull requests linked via external trackers have merged:

Bugzilla bug 1958158 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oauth-proxy/pull/214): >Bug 1958158: providers/openshift: remove logging of authorizer decisions Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.