search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
261 stars 137 forks source link

Bug 1986810: trust the oauth-server when constructing a client to OpenShift #220

Closed stlaz closed 3 years ago

stlaz commented 3 years ago

implements the oauth-proxy part of https://github.com/openshift/enhancements/pull/797

~WIP because: untested~

openshift-ci[bot] commented 3 years ago

@stlaz: This pull request references Bugzilla bug 1986810, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.9.0) matches configured target release for branch (4.9.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liyao@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/oauth-proxy/pull/220): >Bug 1986810: trust the oauth-server when constructing a client to OpenShift Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
s-urbaniak commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)~~ [stlaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 years ago

@stlaz: All pull requests linked via external trackers have merged:

Bugzilla bug 1986810 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oauth-proxy/pull/220): >Bug 1986810: trust the oauth-server when constructing a client to OpenShift Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.