search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
261 stars 137 forks source link

Bug 1966298: Update golang.org/x/net #223

Closed slaskawi closed 3 years ago

slaskawi commented 3 years ago

/assign @stlaz

slaskawi commented 3 years ago

/retest

slaskawi commented 3 years ago

/retest

slaskawi commented 3 years ago

/retest

slaskawi commented 3 years ago

Confirmed, those are flaky tests: https://github.com/openshift/oauth-proxy/pull/226#issuecomment-907079157

s-urbaniak commented 3 years ago

/lgtm

stlaz commented 3 years ago

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, slaskawi, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)~~ [stlaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slaskawi commented 3 years ago

/hold

openshift-ci[bot] commented 3 years ago

@slaskawi: This pull request references Bugzilla bug 1966298, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/oauth-proxy/pull/223): >Bug 1966298: Update golang.org/x/net Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
slaskawi commented 3 years ago

/bugzilla refresh

openshift-ci[bot] commented 3 years ago

@slaskawi: This pull request references Bugzilla bug 1966298, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/oauth-proxy/pull/223#issuecomment-908144989): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
slaskawi commented 3 years ago

/bugzilla refresh

openshift-ci[bot] commented 3 years ago

@slaskawi: This pull request references Bugzilla bug 1966298, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.9.0) matches configured target release for branch (4.9.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @xingxingxia

In response to [this](https://github.com/openshift/oauth-proxy/pull/223#issuecomment-908146724): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
slaskawi commented 3 years ago

/unhold

openshift-ci[bot] commented 3 years ago

@slaskawi: All pull requests linked via external trackers have merged:

Bugzilla bug 1966298 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oauth-proxy/pull/223): >Bug 1966298: Update golang.org/x/net Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
slaskawi commented 3 years ago

/cherry-pick release-4.8

openshift-cherrypick-robot commented 3 years ago

@slaskawi: new pull request created: #227

In response to [this](https://github.com/openshift/oauth-proxy/pull/223#issuecomment-908149625): >/cherry-pick release-4.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 9 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build golang-github-openshift-oauth-proxy-container-v4.9.0-202311250023.p0.g9ea1ebc.assembly.stream for distgit golang-github-openshift-oauth-proxy. All builds following this will include this PR.