Closed clyang82 closed 2 years ago
/retest
@clyang82: This pull request references Bugzilla bug 2026573, which is invalid:
Comment /bugzilla refresh
to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.
/bugzilla refresh
@s-urbaniak: This pull request references Bugzilla bug 2026573, which is invalid:
Comment /bugzilla refresh
to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.
/retest
/test e2e-component
Thanks @s-urbaniak for sharing the history for skip-provider-button
fix. From this issue https://github.com/openshift/oauth-proxy/issues/18, we can see the problem is
When I set -proxy-prefix to , the authentication process works correctly. However, when I also introduce -skip-provider-button, after I perform the login (which seems to work just fine), I am redirected to a URL that omits the / portion, which fails.
For my case, I do not set -proxy-prefix
so that the req.RequestURI is oauth/start
it leads a dead loop. so the fix is to add fine-grained check.
/lgtm cancel
Pre-review: there should not be 3 commits for a single line change, especially Merge branch 'openshift:master' into redirect
does not look correct.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: clyang82, slaskawi To complete the pull request process, please ask for approval from stlaz after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Could you please provide an example of a request that would loop? Also, the explanation of this change should be included in a commit message.
Does the example here help? Let me know if it is unclear. Thanks.
/test e2e-component
/test e2e-component
/retest
/retest
The tests are failing with the proxy returning 500s, please check what's the issue and address it.
/retest
/test e2e-component
/retest
The tests are failing with the proxy returning 500s, please check what's the issue and address it.
run make test-e2e --warn-undefined-variables
in local OCP 4.8, always pass.
/retest-required
/bugzilla refresh
@clyang82: This pull request references Bugzilla bug 2026573, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ytripath@redhat.com), skipping review request.
/bugzilla refresh
The requirements for Bugzilla bugs have changed (BZs linked to PRs on master branch need to target OCP 4.11), recalculating validity.
@openshift-bot: This pull request references Bugzilla bug 2026573, which is invalid:
Comment /bugzilla refresh
to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.
/bugzilla refresh
@clyang82: This pull request references Bugzilla bug 2026573, which is invalid:
Comment /bugzilla refresh
to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.
/retest
@clyang82: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-component | e105658cb1a883263095dee88f67e77da1920132 | link | true | /test e2e-component |
Full PR test history. Your PR dashboard.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
@clyang82, as mentioned in the issue, it is a misconfiguration, please check my response on your issue: https://github.com/openshift/oauth-proxy/issues/232.
We can't just add a custom path to make your solution work in particular. We would need to add a feature flag (which defaults to turned off) and it would allow relative paths (set by rd
or conservation of the relative path in the first place) on skip-provider-button=true
, which seems to be the issue.
@clyang82: This pull request references Bugzilla bug 2026573. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. Warning: Failed to comment on Bugzilla bug with reason for changed state.
fixes: https://github.com/openshift/oauth-proxy/issues/232
req.RequestURI
isoauth/start
so there is a dead loop, because the request is fromxxx/oauth/start
. It can be reproduced by entering the urlxxx/oauth/sign_in
orxxx/oauth/start
into the browsers.Signed-off-by: clyang82 chuyang@redhat.com