search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
261 stars 136 forks source link

Bug 2026860: ocp provider: don't fail client creation if oauth-server cert is not present #238

Closed stlaz closed 2 years ago

stlaz commented 2 years ago

Newer oauth-proxy versions can be used in older clusters where the oauth-server certificate is not present. We should not fail client creation in those cases.

/assign @s-urbaniak /cc @openshift/openshift-team-multi-cluster-maintainers

openshift-ci[bot] commented 2 years ago

@stlaz: This pull request references Bugzilla bug 2026860, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.10.0) matches configured target release for branch (4.10.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @xingxingxia

In response to [this](https://github.com/openshift/oauth-proxy/pull/238): >Bug 2026860: ocp provider: don't fail client creation if oauth-server cert is not present Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stlaz commented 2 years ago

/test unit

openshift-ci[bot] commented 2 years ago

@stlaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibihim, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)~~ [stlaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@stlaz: All pull requests linked via external trackers have merged:

Bugzilla bug 2026860 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oauth-proxy/pull/238): >Bug 2026860: ocp provider: don't fail client creation if oauth-server cert is not present Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 year ago

[ART PR BUILD NOTIFIER]

This PR has been included in build golang-github-openshift-oauth-proxy-container-v4.10.0-202305011254.p0.g799d414.assembly.stream for distgit golang-github-openshift-oauth-proxy. All builds following this will include this PR.