search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
261 stars 136 forks source link

Use resourceName in Openshift SAR rule #243

Closed samuelvl closed 2 years ago

samuelvl commented 2 years ago

If name is used the rule is not evaluated correctly because the Openshift SAR only supports resourceName.

oc explain subjectaccessreview --api-version=authorization.openshift.io/v1
samuelvl commented 2 years ago

/retest

samuelvl commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@samuelvl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
samuelvl commented 2 years ago

/cc @ibihim

stlaz commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samuelvl, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)~~ [stlaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stlaz commented 2 years ago

This is a docs/test fix, I don't need a BZ for that. Adding the BZ label for this to merge.

openshift-bot commented 9 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build golang-github-openshift-oauth-proxy-container-v4.11.0-202311211130.p0.gaad1b28.assembly.stream for distgit golang-github-openshift-oauth-proxy. All builds following this will include this PR.