search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
261 stars 136 forks source link

AUTH-373: add audit-ID headers to TokenReview and SAR requests #252

Closed stlaz closed 1 year ago

stlaz commented 1 year ago

Adds an Audit-ID header to help troubleshoot TokenReview and SAR issues.

Also PR bumps the golang build image, kube and lib-go.

/cc @deads2k @ibihim

deads2k commented 1 year ago

once we show this installing, @dgoodwin could you/forrest kick the correct /payload job for 4.14 to see these lines appear?

dgoodwin commented 1 year ago

/payload 4.14 ci blocking

openshift-ci[bot] commented 1 year ago

@dgoodwin: trigger 4 job(s) of type blocking for the ci release of OCP 4.14

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a316e6d0-c3fe-11ed-98bd-4daf04ae1e93-0

stlaz commented 1 year ago

something broke during the bump, let me try to fix that

stlaz commented 1 year ago

/payload 4.14 ci blocking

openshift-ci[bot] commented 1 year ago

@stlaz: trigger 4 job(s) of type blocking for the ci release of OCP 4.14

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/626ad490-c4b0-11ed-9e55-a48e9f12e7ac-0

stlaz commented 1 year ago

/test e2e-component

stlaz commented 1 year ago

/test e2e-component installation issue

stlaz commented 1 year ago

/test e2e-component installation issue

stlaz commented 1 year ago

/test e2e-component

stlaz commented 1 year ago

/test e2e-component unrelated

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibihim, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)~~ [stlaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stlaz commented 1 year ago

/retest-required

openshift-ci[bot] commented 1 year ago

@stlaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 year ago

@stlaz: This pull request references AUTH-373 which is a valid jira issue.

In response to [this](https://github.com/openshift/oauth-proxy/pull/252): >Adds an Audit-ID header to help troubleshoot TokenReview and SAR issues. > >Also PR bumps the golang build image, kube and lib-go. > >/cc @deads2k @ibihim Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
neisw commented 1 year ago

/payload 4.14 ci blocking

openshift-ci[bot] commented 1 year ago

@neisw: trigger 4 job(s) of type blocking for the ci release of OCP 4.14

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/da175e30-ff04-11ed-91a1-88921c6eba1f-0

neisw commented 1 year ago

/payload 4.14 ci blocking

openshift-ci[bot] commented 1 year ago

@neisw: trigger 4 job(s) of type blocking for the ci release of OCP 4.14

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f5e7b7e0-ff4a-11ed-81b3-9a0cfb6ec350-0

stbenjam commented 1 year ago

/label jira/valid-bug