search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
261 stars 136 forks source link

OCPBUGS-14033: Handle TERM signal gracefully #255

Closed simonpasquier closed 1 year ago

simonpasquier commented 1 year ago

When a pod is evicted, the container runtime will send a TERM signal to the PID 1 of all containers. If a container doesn't catch the signal, the process will exit with a non-zero code and Kubernetes might consider the pod status to be Failed.

See https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination

openshift-ci-robot commented 1 year ago

@simonpasquier: This pull request references Jira Issue OCPBUGS-14033, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oauth-proxy/pull/255): >When a pod is evicted, the container runtime will send a TERM signal to the PID 1 of all containers. If a container doesn't catch the signal, the process will exit with a non-zero code and Kubernetes might consider the pod status to be Failed. > >See >https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
simonpasquier commented 1 year ago

/hold

simonpasquier commented 1 year ago

/test e2e-component

simonpasquier commented 1 year ago

/test e2e-component

simonpasquier commented 1 year ago

/hold cancel

simonpasquier commented 1 year ago

/assign @stlaz

simonpasquier commented 1 year ago

/test e2e-component

simonpasquier commented 1 year ago

/test e2e-component

openshift-ci[bot] commented 1 year ago

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
deads2k commented 1 year ago

should help us exit cleanly. wiring missed http

/lgtm /approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

@simonpasquier: Jira Issue OCPBUGS-14033: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-14033 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oauth-proxy/pull/255): >When a pod is evicted, the container runtime will send a TERM signal to the PID 1 of all containers. If a container doesn't catch the signal, the process will exit with a non-zero code and Kubernetes might consider the pod status to be Failed. > >See >https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-termination Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.