Closed kwilczynski closed 1 year ago
@kwilczynski: This pull request references APPSRE-7970 which is a valid jira issue.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/test all
/retest
To the reviewer:
The currently failing test seems to be failing for reasons that aren't related to the changes here.
Update:
Tests seem flaky. Things eventually passed.
@kwilczynski: This pull request references APPSRE-7970 which is a valid jira issue.
@stlaz, this should be ready for review. Thank you!
/retest-required
Hi @sttts, @stlaz and @deads2k,
Would any of you have a moment to look at this change? I would appreciate it.
I had a brief chat with @stlaz, who requested several changes:
This will be done in due course.
@kwilczynski: This pull request references APPSRE-7970 which is a valid jira issue.
/retest-required
/test e2e-aws
@kwilczynski: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kwilczynski, stlaz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Currently, there is no support for configuring the timeout between the proxy and the backends, and as such, the default timeout of 30 seconds is applied (as per Go's standard library defaults). When the timeout occurs, the user will see an "http: proxy error: context canceled" in the logs, and the remote client will receive a 502 error.
The default timeout might not be sufficient for some services, especially as every upstream service differs, and the abrupt connection termination might not be desirable. Typically, most upstream services only send response headers after they have gathered/processed all necessary data.
Thus, add a new command-line switch called
--upstream-timeout
, allowing users to configure the timeout setting.Note: this change is, almost entirely, a backport of a change that was added to the upstream OAuth2 Proxy project some time ago, per:
Signed-off-by: Krzysztof Wilczyński kwilczynski@redhat.com