Open openshift-bot opened 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: openshift-bot Once this PR has been reviewed and has the lgtm label, please assign stlaz for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@openshift-bot: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/verify | fad47c8ea30ccd5e4dc4e7e3aadc3d5f8d4e05c7 | link | true | /test verify |
ci/prow/e2e-component | fad47c8ea30ccd5e4dc4e7e3aadc3d5f8d4e05c7 | link | true | /test e2e-component |
Full PR test history. Your PR dashboard.
Updating golang-github-openshift-oauth-proxy-container image to be consistent with ART for 4.12 TLDR: Product builds by ART can be configured for different base and builder images than corresponding CI builds. This automated PR requests a change to CI configuration to align with ART's configuration; please take steps to merge it quickly or contact ART to coordinate changes.
The configuration in the following ART component metadata is driving this alignment request: golang-github-openshift-oauth-proxy.yml.
Detail:
This repository is out of sync with the downstream product builds for this component. The CI configuration for at least one image differs from ART's expected product configuration. This should be addressed to ensure that the component's CI testing accurate reflects what customers will experience.
Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a different version, usually prior to GA. The intent is to effect changes in both configurations simultaneously without breaking either CI or ART builds, so usually ART builds are configured to consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may also configure changes in GA releases with CI remaining canonical for a brief grace period to enable CI to succeed and the alignment PR to merge. In either case, ART configuration will be made canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is important to align CI configuration as soon as possible.
PRs are also triggered when CI configuration changes without ART coordination, for instance to change the number of builder images or to use a different golang version. These changes should be coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated first to enable the changes to occur simultaneously in both CI and ART at the same time. This also gives ART a chance to validate the intended changes first. For instance, ART compiles most components with the Golang version being used by the control plane for a given OpenShift release. Exceptions to this convention (i.e. you believe your component must be compiled with a Golang version independent from the control plane) must be granted by the OpenShift staff engineers and communicated to the ART team.
Roles & Responsibilities:
@release-artists
in#forum-ocp-art
on Slack. If necessary, the changes required by this pull request can be introduced with a separate PR opened by the component team. Once the repository is aligned, this PR will be closed automatically.verify-deps
is complaining. In that case, please open a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:
Change behavior of future PRs:
auto_label
attribute in the image configuration. ExampleUPSTREAM: <carry>:
. An example.If you have any questions about this pull request, please reach out to
@release-artists
in the#forum-ocp-art
coreos slack channel.