search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
261 stars 136 forks source link

OCPBUGS-23102: Revert #266 "OCPBUGS-21718: go.mod: bump golang.org/x/net to v0.17.0" #268

Closed stbenjam closed 9 months ago

stbenjam commented 9 months ago

Reverts #266 ; tracked by OCPBUGS-23102

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

All metal jobs are broken and we don't have an obvious culprit, TRT is floating a few reverts for investigation.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

N/A

CC: @s-urbaniak

PR created by Revertomatic:tm:
openshift-ci-robot commented 9 months ago

@stbenjam: This pull request references Jira Issue OCPBUGS-23102, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oauth-proxy/pull/268): > >Reverts #266 ; tracked by OCPBUGS-23102 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >All metal jobs are broken and we don't have an obvious culprit, TRT is floating a few reverts for investigation. > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >N/A >``` > >CC: @s-urbaniak > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
stbenjam commented 9 months ago

/hold /payload-job periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-ipv6

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam Once this PR has been reviewed and has the lgtm label, please assign stlaz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 9 months ago

@stbenjam: trigger 1 job(s) for the /payload-(job|aggregate) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/78a5a300-7f01-11ee-9b57-8ae3bf59e63a-0

stbenjam commented 9 months ago

/close

It was https://github.com/openshift/origin/pull/28389

openshift-ci-robot commented 9 months ago

@stbenjam: This pull request references Jira Issue OCPBUGS-23102. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oauth-proxy/pull/268): > >Reverts #266 ; tracked by OCPBUGS-23102 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >All metal jobs are broken and we don't have an obvious culprit, TRT is floating a few reverts for investigation. > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >N/A >``` > >CC: @s-urbaniak > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.