openshift-ci-robot
commented
8 months ago @openshift-bot: This pull request references Jira Issue OCPBUGS-25776, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
* bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)Requesting review from QA contact: /cc @xingxingxia
The bug has been updated to refer to the pull request using the external bug tracker.
In response to [this](https://github.com/openshift/oauth-proxy/pull/271):
>Updating golang-github-openshift-oauth-proxy-container image to be consistent with ART for 4.16
>__TLDR__:
>Product builds replace base and builder images as configured. This PR is to ensure
>that CI builds use the same base images as the product builds.
>
>Component owners, please ensure that this PR merges as it impacts the fidelity
>of your CI signal. Patch-manager / leads, this PR is a no-op from a product
>perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the
>PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is
>to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test
>to remove this tag and help the PR to merge.
>
>__Detail__:
>This repository is out of sync with the downstream product builds for this component.
>One or more images differ from those being used by ART to create product builds. This
>should be addressed to ensure that the component's CI testing is accurately
>reflecting what customers will experience.
>
>The information within the following ART component metadata is driving this alignment
>request: [golang-github-openshift-oauth-proxy.yml](https://github.com/openshift/ocp-build-data/tree/af2133c5194e28075efb48f4b508a98759b079d2/images/golang-github-openshift-oauth-proxy.yml).
>
>The vast majority of these PRs are opened because a different Golang version is being
>used to build the downstream component. ART compiles most components with the version
>of Golang being used by the control plane for a given OpenShift release. Exceptions
>to this convention (i.e. you believe your component must be compiled with a Golang
>version independent from the control plane) must be granted by the OpenShift
>architecture team and communicated to the ART team.
>
>__Roles & Responsibilities__:
>- Component owners are responsible for ensuring these alignment PRs merge with passing
> tests OR that necessary metadata changes are reported to the ART team: `@release-artists`
> in `#forum-ocp-art` on Slack. If necessary, the changes required by this pull request can be
> introduced with a separate PR opened by the component team. Once the repository is aligned,
> this PR will be closed automatically.
>- Patch-manager or those with sufficient privileges within this repository may add
> any required labels to ensure the PR merges once tests are passing. Downstream builds
> are *already* being built with these changes. Merging this PR only improves the fidelity
> of our CI.
>
>ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
>In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:
>```
>build_root:
> from_repository: true
>```
>
>__Change behavior of future PRs__:
>* In case you just want to follow the base images that ART suggests, you can configure additional labels to be
> set up automatically. This means that such a PR would *merge without human intervention* (and awareness!) in the future.
> To do so, open a PR to set the `auto_label` attribute in the image configuration. [Example](https://github.com/openshift-eng/ocp-build-data/pull/1778)
>* You can set a commit prefix, like `UPSTREAM: : `. [An example](https://github.com/openshift-eng/ocp-build-data/blob/6831b59dddc5b63282076d3abe04593ad1945148/images/ose-cluster-api.yml#L11).
>
>If you have any questions about this pull request, please reach out to `@release-artists` in the `#forum-ocp-art` coreos slack channel.
>
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
joepvd
mfojtik
ibihim
stlaz
openshift-ci[bot]
wallylewis
Updating golang-github-openshift-oauth-proxy-container image to be consistent with ART for 4.16 TLDR: Product builds by ART can be configured for different base and builder images than corresponding CI builds. This automated PR requests a change to CI configuration to align with ART's configuration; please take steps to merge it quickly or contact ART to coordinate changes.
The configuration in the following ART component metadata is driving this alignment request: golang-github-openshift-oauth-proxy.yml.
Detail:
This repository is out of sync with the downstream product builds for this component. The CI configuration for at least one image differs from ART's expected product configuration. This should be addressed to ensure that the component's CI testing accurate reflects what customers will experience.
Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a different version, usually prior to GA. The intent is to effect changes in both configurations simultaneously without breaking either CI or ART builds, so usually ART builds are configured to consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may also configure changes in GA releases with CI remaining canonical for a brief grace period to enable CI to succeed and the alignment PR to merge. In either case, ART configuration will be made canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is important to align CI configuration as soon as possible.
PRs are also triggered when CI configuration changes without ART coordination, for instance to change the number of builder images or to use a different golang version. These changes should be coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated first to enable the changes to occur simultaneously in both CI and ART at the same time. This also gives ART a chance to validate the intended changes first. For instance, ART compiles most components with the Golang version being used by the control plane for a given OpenShift release. Exceptions to this convention (i.e. you believe your component must be compiled with a Golang version independent from the control plane) must be granted by the OpenShift staff engineers and communicated to the ART team.
Roles & Responsibilities:
@release-artistsin#forum-ocp-arton Slack. If necessary, the changes required by this pull request can be introduced with a separate PR opened by the component team. Once the repository is aligned, this PR will be closed automatically.verify-depsis complaining. In that case, please open a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:
Change behavior of future PRs:
auto_labelattribute in the image configuration. ExampleUPSTREAM: <carry>:. An example.If you have any questions about this pull request, please reach out to
@release-artistsin the#forum-ocp-artcoreos slack channel.