search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
261 stars 136 forks source link

htpasswd: add hot reload #275

Closed danilo-gemoli closed 3 months ago

danilo-gemoli commented 4 months ago

Allow HtpasswdFile to watch and reload new user entries when the file changes. This feature might come handy when someone wants to update the password file without restarting the service.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danilo-gemoli Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
danilo-gemoli commented 4 months ago

/retest-required

openshift-ci[bot] commented 4 months ago

@danilo-gemoli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-component 0ea917cece6cf1a6231cd67d573b5c493c0dc89f link true /test e2e-component

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
danilo-gemoli commented 3 months ago

/close Team say the repo is in maintenance mode only, no new features get in.

openshift-ci[bot] commented 3 months ago

@danilo-gemoli: Closed this PR.

In response to [this](https://github.com/openshift/oauth-proxy/pull/275#issuecomment-2082718968): >/close >Team say the repo is in maintenance mode only, no new features get in. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.