search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
263 stars 138 forks source link

fixed sar-examples #94

Closed sixtyeight closed 5 years ago

sixtyeight commented 6 years ago

Using the provided SubjectAccessReview examples will result in an access denied decision in case the user cannot LIST the given resource-type. As OpenShift looks for a "resourceName" property and not the "name" property it executes a LIST for the resource-type instead of the expected GET on resource-type / resource-name.

https://docs.openshift.com/container-platform/3.11/rest_api/oapi/v1.SubjectAccessReview.html#object-schema

openshift-ci-robot commented 6 years ago

Hi @sixtyeight. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pgier commented 6 years ago

/ok-to-test

mrogers950 commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

@sixtyeight: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 1222adfd39227143cb2d391a84f5ef3951f89b6f link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).