search

openshift / oauth-proxy

A reverse proxy that provides authentication with OpenShift via OAuth and Kubernetes service accounts
MIT License
263 stars 138 forks source link

fixing http/s proxy handling for openshift provider #96

Closed patlachance closed 5 years ago

patlachance commented 5 years ago

Fixes #71

openshift-ci-robot commented 5 years ago

Hi @patlachance. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pgier commented 5 years ago

/ok-to-test

brancz commented 5 years ago

@openshift/sig-auth

mrogers950 commented 5 years ago

@patlachance please modify your patch to set the transport proxy outside of setCA() (after it's called in LoadDefaults()). That's my only feedback and then we will be OK to merge.

patlachance commented 5 years ago

@mrogers950 please see comment on your review. Don't know how to do it without managing custom CA at the same time.

mrogers950 commented 5 years ago

@patlachance sorry for the delay, I see what you're saying about setting the transport here. If you can also change the function name to setCAandTransportProxy or similar, that would be acceptable, just to make it clear that the function is doing both of these things.

patlachance commented 5 years ago

@mrogers950 ok I’ll do it over the weekend.

mrogers950 commented 5 years ago

/test all

mrogers950 commented 5 years ago

@patlachance I'm still waiting on your fixup. I'd be willing to open a separate PR and push the fix through myself if you have not had the time to return to this, just let me know.

patlachance commented 5 years ago

@mrogers950 sorry for the delay. Done now!

openshift-ci-robot commented 5 years ago

@patlachance: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/openshift/oauth-proxy/pull/96#issuecomment-460039012): >@mrogers950 sorry for the delay. Done now! Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mrogers950 commented 5 years ago

@patlachance looks good, thank you for your contribution! /lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrogers950, patlachance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oauth-proxy/blob/master/OWNERS)~~ [mrogers950] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mrogers950 commented 5 years ago

/ok-to-test

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.