search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
82 stars 80 forks source link

CLID-62,CLID-63: moves pkg dir to internal dir #839

Closed aguidirh closed 2 months ago

aguidirh commented 2 months ago

Description

As oc-mirror is not a library, all the packages in v2 were moved under internal folder. In this way we prevent other go mod creating an undesired oc-mirror dependency.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

The following tests were executed:

All automated tests passing

Mirror To Disk

Disk To Mirror

Mirror To Mirror

Delete

Expected Outcome

All flows above should be executed without errors and the containers images should be pulled/pushed/deleted according to the flow executed.

openshift-ci-robot commented 2 months ago

@aguidirh: This pull request references CLID-62 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

This pull request references CLID-63 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/oc-mirror/pull/839): ># Description > >As oc-mirror is not a library, all the packages in v2 were moved under internal folder. In this way we prevent other go mod creating an undesired oc-mirror dependency. > >## Type of change > >Please delete options that are not relevant. > >- [ ] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >The following tests were executed: > >`All automated tests passing` > >`Mirror To Disk` > >`Disk To Mirror` > >`Mirror To Mirror` > >`Delete` > >## Expected Outcome > >All flows above should be executed without errors and the containers images should be pulled/pushed/deleted according to the flow executed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@aguidirh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
lmzuccarelli commented 2 months ago

Verified locally using mirror to disk workflow, also double checked make build, make test etc

lmzuccarelli commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh, lmzuccarelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [aguidirh,lmzuccarelli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.16.0-202404241818.p0.gffa56b6.assembly.stream.el9 for distgit oc-mirror-plugin. All builds following this will include this PR.