search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
82 stars 80 forks source link

OCPBUGS-31092: Fix archive tar file size to respect the archiveSize s… #842

Closed sherine-k closed 2 months ago

sherine-k commented 2 months ago

Description

Fix archive tar file size to respect the archiveSize setting when mirror with V2 format

Fixes # OCPBUGS-31092

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Mirror to disk with the following ISC should pass 

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
archiveSize: 8
mirror:
  # platform:
  #   channels:
  #   - name: stable-4.13
  #   graph: true
  operators:
  - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15
    packages:
    - name: advanced-cluster-management                                  
      channels:
      - name: release-2.9             
    - name: compliance-operator
      channels:
      - name: stable
    - name: multicluster-engine
      channels:
      - name: stable-2.4
      - name: stable-2.5
  additionalImages:
  - name: registry.redhat.io/ubi8/ubi:latest                        
  - name: registry.redhat.io/rhel8/support-tools:latest
  - name: registry.access.redhat.com/ubi8/nginx-120:latest
  - name: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0
  - name: registry.k8s.io/sig-storage/csi-resizer:v1.8.0

Expected Outcome

$ ls -lh  ~/clid20/
total 12G
-rw-r--r--. 1 skhoury skhoury 7.9G Apr 29 15:57 mirror_000001.tar
-rw-r--r--. 1 skhoury skhoury 3.8G Apr 29 15:57 mirror_000002.tar
drwxr-xr-x. 1 skhoury skhoury  262 Apr 29 15:50 working-dir
openshift-ci-robot commented 2 months ago

@sherine-k: This pull request references Jira Issue OCPBUGS-31092, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/842): ># Description > >Fix archive tar file size to respect the archiveSize setting when mirror with V2 format > >Fixes # OCPBUGS-31092 > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Mirror to disk with the following ISC should pass >```yaml >kind: ImageSetConfiguration >apiVersion: mirror.openshift.io/v2alpha1 >archiveSize: 8 >mirror: > # platform: > # channels: > # - name: stable-4.13 > # graph: true > operators: > - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15 > packages: > - name: advanced-cluster-management > channels: > - name: release-2.9 > - name: compliance-operator > channels: > - name: stable > - name: multicluster-engine > channels: > - name: stable-2.4 > - name: stable-2.5 > additionalImages: > - name: registry.redhat.io/ubi8/ubi:latest > - name: registry.redhat.io/rhel8/support-tools:latest > - name: registry.access.redhat.com/ubi8/nginx-120:latest > - name: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0 > - name: registry.k8s.io/sig-storage/csi-resizer:v1.8.0 >``` > >## Expected Outcome >```bash >$ ls -lh ~/clid20/ >total 12G >-rw-r--r--. 1 skhoury skhoury 7.9G Apr 29 15:57 mirror_000001.tar >-rw-r--r--. 1 skhoury skhoury 3.8G Apr 29 15:57 mirror_000002.tar >drwxr-xr-x. 1 skhoury skhoury 262 Apr 29 15:50 working-dir >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sherine-k commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@sherine-k: This pull request references Jira Issue OCPBUGS-31092, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc-mirror/pull/842#issuecomment-2082854604): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aguidirh commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh, sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [aguidirh,sherine-k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@sherine-k: Jira Issue OCPBUGS-31092: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31092 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/842): ># Description > >Fix archive tar file size to respect the archiveSize setting when mirror with V2 format > >Fixes # OCPBUGS-31092 > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Mirror to disk with the following ISC should pass >```yaml >kind: ImageSetConfiguration >apiVersion: mirror.openshift.io/v2alpha1 >archiveSize: 8 >mirror: > # platform: > # channels: > # - name: stable-4.13 > # graph: true > operators: > - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15 > packages: > - name: advanced-cluster-management > channels: > - name: release-2.9 > - name: compliance-operator > channels: > - name: stable > - name: multicluster-engine > channels: > - name: stable-2.4 > - name: stable-2.5 > additionalImages: > - name: registry.redhat.io/ubi8/ubi:latest > - name: registry.redhat.io/rhel8/support-tools:latest > - name: registry.access.redhat.com/ubi8/nginx-120:latest > - name: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0 > - name: registry.k8s.io/sig-storage/csi-resizer:v1.8.0 >``` > >## Expected Outcome >```bash >$ ls -lh ~/clid20/ >total 12G >-rw-r--r--. 1 skhoury skhoury 7.9G Apr 29 15:57 mirror_000001.tar >-rw-r--r--. 1 skhoury skhoury 3.8G Apr 29 15:57 mirror_000002.tar >drwxr-xr-x. 1 skhoury skhoury 262 Apr 29 15:50 working-dir >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sherine-k commented 2 months ago

/reopen

openshift-ci[bot] commented 2 months ago

@sherine-k: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened.

In response to [this](https://github.com/openshift/oc-mirror/pull/842#issuecomment-2085062131): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.17.0-202404301246.p0.gd0c3c47.assembly.stream.el9 for distgit oc-mirror-plugin. All builds following this will include this PR.

openshift-merge-robot commented 2 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-05-01-111315