openshift-ci-robot
commented
4 months ago @sherine-k: This pull request references Jira Issue OCPBUGS-31608, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to [this](https://github.com/openshift/oc-mirror/pull/850):
># Description
>
> Fix source repository for IDMS/ITMS in case of empty namespace
>
>This also clears the cluster-resources folder while setting up the working-dir, so that old itms , catalogsrouce files don't stay stale in the folder, and get dragged into the tar file.
>
>It also fixes dry-run for mirror-to-disk mode which was checking and not finding any of the images in the cache due to the fact that it was using a srcImage context (tls enabled) instead of the destImage context (tls disabled for the cache registry)
>
>Fixes # (issue)
>
>## Type of change
>
>Please delete options that are not relevant.
>
>- [x] Bug fix (non-breaking change which fixes an issue)
>- [ ] New feature (non-breaking change which adds functionality)
>- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
>- [ ] This change requires a documentation update
>
># How Has This Been Tested?
>Using the following imageSetConfig, perform a mirror to disk followed by disk to mirror as stated in the jira issue:
>```yaml
>apiVersion: mirror.openshift.io/v2alpha1
>kind: ImageSetConfiguration
>mirror:
> operators:
> - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15
> packages:
> - name: devworkspace-operator
> minVersion: "0.23.0"
> - name: quay-operator
> maxVersion: "3.10.2"
> - name: cluster-logging
> minVersion: 5.8.3
> maxVersion: 5.8.5
>```
>
>## Expected Outcome
>the working-dir/cluster-resources folder should contain 2 files only
>* cs-redhat-operator-index-v4-15.yaml
>* idms-oc-mirror.yaml
>
>The idms-oc-mirror.yaml file should contain the following imageDigestMirrors:
>```yaml
> imageDigestMirrors:
> - mirrors:
> - localhost:5000/31608/devworkspace
> source: registry.redhat.io/devworkspace
> - mirrors:
> - localhost:5000/31608/openshift4
> source: registry.redhat.io/openshift4
> - mirrors:
> - localhost:5000/31608
> source: registry.redhat.io
>
>```
>
>The last `source` should be `registry.redhat.io`, and not `registry.redhat.io**/**`
>
Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot]
sherine-k
zhouying7780
lmzuccarelli
openshift-merge-robot
Description
Fix source repository for IDMS/ITMS in case of empty namespace
This also clears the cluster-resources folder while setting up the working-dir, so that old itms , catalogsrouce files don't stay stale in the folder, and get dragged into the tar file.
It also fixes dry-run for mirror-to-disk mode which was checking and not finding any of the images in the cache due to the fact that it was using a srcImage context (tls enabled) instead of the destImage context (tls disabled for the cache registry)
Fixes # OCPBUGS-31608
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Using the following imageSetConfig, perform a mirror to disk followed by disk to mirror as stated in the jira issue:
Expected Outcome
the working-dir/cluster-resources folder should contain 2 files only
The idms-oc-mirror.yaml file should contain the following imageDigestMirrors:
The last
sourceshould beregistry.redhat.io, and notregistry.redhat.io**/**