search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
82 stars 80 forks source link

OCPBUGS-31622: Fix operator related image has empty reference #851

Closed sherine-k closed 1 month ago

sherine-k commented 1 month ago

Description

Fixes # OCPBUGS-31622 This was specific to seldon-operator (community catalog)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Additional unit test covering the use case. Successfully performed M2D + D2M with the following imagesetconfig

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
mirror:
  operators:
    - catalog: oci:///home/skhoury/redhat-index-all
      packages:
        - name: aws-load-balancer-operator
    - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15
      packages:
       - name: elasticsearch-operator
    - catalog: registry.redhat.io/redhat/redhat-marketplace-index:v4.15
      packages:
      - name: datadog-operator-certified-rhmp
    - catalog: registry.redhat.io/redhat/certified-operator-index:v4.15
      packages:
      - name: portworx-certified
    - catalog: registry.redhat.io/redhat/community-operator-index:v4.15
      packages:
      - name: seldon-operator

Expected Outcome

Both M2D and D2M successfully complete

openshift-ci-robot commented 1 month ago

@sherine-k: This pull request references Jira Issue OCPBUGS-31622, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/851): ># Description > >Fixes # OCPBUGS-31622 >This was specific to seldon-operator (community catalog) > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? >Additional unit test covering the use case. >Successfully performed M2D + D2M with the following imagesetconfig >```yaml >kind: ImageSetConfiguration >apiVersion: mirror.openshift.io/v2alpha1 >mirror: > operators: > - catalog: oci:///home/skhoury/redhat-index-all > packages: > - name: aws-load-balancer-operator > - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15 > packages: > - name: elasticsearch-operator > - catalog: registry.redhat.io/redhat/redhat-marketplace-index:v4.15 > packages: > - name: datadog-operator-certified-rhmp > - catalog: registry.redhat.io/redhat/certified-operator-index:v4.15 > packages: > - name: portworx-certified > - catalog: registry.redhat.io/redhat/community-operator-index:v4.15 > packages: > - name: seldon-operator >``` > >## Expected Outcome >Both M2D and D2M successfully complete Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [sherine-k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhouying7780 commented 1 month ago

/label qe-approved

lmzuccarelli commented 1 month ago

/label acknowledge-critical-fixes-only /lgtm

lmzuccarelli commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@lmzuccarelli: This pull request references Jira Issue OCPBUGS-31622, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc-mirror/pull/851#issuecomment-2114274486): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@sherine-k: Jira Issue OCPBUGS-31622: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31622 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/851): ># Description > >Fixes # OCPBUGS-31622 >This was specific to seldon-operator (community catalog) > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? >Additional unit test covering the use case. >Successfully performed M2D + D2M with the following imagesetconfig >```yaml >kind: ImageSetConfiguration >apiVersion: mirror.openshift.io/v2alpha1 >mirror: > operators: > - catalog: oci:///home/skhoury/redhat-index-all > packages: > - name: aws-load-balancer-operator > - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15 > packages: > - name: elasticsearch-operator > - catalog: registry.redhat.io/redhat/redhat-marketplace-index:v4.15 > packages: > - name: datadog-operator-certified-rhmp > - catalog: registry.redhat.io/redhat/certified-operator-index:v4.15 > packages: > - name: portworx-certified > - catalog: registry.redhat.io/redhat/community-operator-index:v4.15 > packages: > - name: seldon-operator >``` > >## Expected Outcome >Both M2D and D2M successfully complete Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.16.0-202405160942.p0.g55952d1.assembly.stream.el9 for distgit oc-mirror-plugin. All builds following this will include this PR.

openshift-merge-robot commented 1 month ago

Fix included in accepted release 4.16.0-0.nightly-2024-05-17-180525