openshift-ci-robot
commented
1 month ago @lmzuccarelli: This pull request references Jira Issue OCPBUGS-33196, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to [this](https://github.com/openshift/oc-mirror/pull/853):
># Description
>
>This addresses the issue when images being mirrored, having both tag and digest would cause the mirror execution to fail, the fix ensures these type images will be skipped with an appropriate warning message.
>
>Fixes # OCPBUGS-33196
>
>## Type of change
>
>- [x] Bug fix (non-breaking change which fixes an issue)
>- [ ] New feature (non-breaking change which adds functionality)
>- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
>- [ ] This change requires a documentation update
>
># How Has This Been Tested?
>
>I used the following imagesetconfig for testing
>
>```
>kind: ImageSetConfiguration
>apiVersion: mirror.openshift.io/v2alpha1
>mirror:
> additionalImages:
> - name: quay.io/cilium/cilium-etcd-operator:v2.0.7@sha256:04b8327f7f992693c2cb483b999041ed8f92efc8e14f2a5f3ab95574a65ea2dc
> - name: quay.io/coreos/etcd:v3.5.4@sha256:a67fb152d4c53223e96e818420c37f11d05c2d92cf62c05ca5604066c37295e9
>
>```
>
>Executed the following mirror to disk workflow
>
>```
>bin/oc-mirror --config ocpbugs-33196.yaml file://taganddigest --v2
>```
>
>## Expected Outcome
>
>```
>2024/05/14 14:18:35 [WARN] : ⚠️ --v2 flag identified, flow redirected to the oc-mirror v2 version. This is Tech Preview, it is still under development and it is not production ready.
>2024/05/14 14:18:35 [INFO] : 👋 Hello, welcome to oc-mirror
>2024/05/14 14:18:35 [INFO] : ⚙️ setting up the environment for you...
>2024/05/14 14:18:35 [INFO] : 🔀 workflow mode: mirrorToDisk
>2024/05/14 14:18:35 [INFO] : 🕵️ going to discover the necessary images...
>2024/05/14 14:18:35 [INFO] : 🔍 collecting release images...
>2024/05/14 14:18:35 [INFO] : 🔍 collecting operator images...
>2024/05/14 14:18:35 [INFO] : 🔍 collecting additional images...
>2024/05/14 14:18:35 [WARN] : [AdditionalImagesCollector] mirroring skipped : source image quay.io/cilium/cilium-etcd-operator:v2.0.7@sha256:04b8327f7f992693c2cb483b999041ed8f92efc8e14f2a5f3ab95574a65ea2dc has both tag and digest
>2024/05/14 14:18:35 [WARN] : [AdditionalImagesCollector] mirroring skipped : source image quay.io/coreos/etcd:v3.5.4@sha256:a67fb152d4c53223e96e818420c37f11d05c2d92cf62c05ca5604066c37295e9 has both tag and digest
>2024/05/14 14:18:35 [INFO] : 🚀 Start copying the images...
>2024/05/14 14:18:35 [INFO] : === Results ===
>2024/05/14 14:18:35 [INFO] : All release images mirrored successfully 0 / 0 ✅
>2024/05/14 14:18:35 [INFO] : All operator images mirrored successfully 0 / 0 ✅
>2024/05/14 14:18:35 [INFO] : All additional images mirrored successfully 0 / 0 ✅
>2024/05/14 14:18:35 [INFO] : 📦 Preparing the tarball archive...
>2024/05/14 14:18:35 [INFO] : mirror time : 1.770588ms
>2024/05/14 14:18:35 [INFO] : 👋 Goodbye, thank you for using oc-mirror
>
>```
>
Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lmzuccarelli
openshift-ci[bot]
kasturinarra
sherine-k
openshift-bot
openshift-merge-robot
Description
This addresses the issue when images being mirrored, having both tag and digest would cause the mirror execution to fail, the fix ensures these type images will be skipped with an appropriate warning message.
Fixes # OCPBUGS-33196
Type of change
How Has This Been Tested?
I used the following imagesetconfig for testing
Executed the following mirror to disk workflow
Expected Outcome