openshift-ci-robot
commented
1 month ago @sherine-k: This pull request references Jira Issue OCPBUGS-33580, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
* bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)Requesting review from QA contact: /cc @zhouying7780
The bug has been updated to refer to the pull request using the external bug tracker.
In response to [this](https://github.com/openshift/oc-mirror/pull/856):
># Description
>
>When selecting the release nodes that correspond to the filtering, we were using a slice. duplicates nodes lead to mirroring the release content more than once.
>The fix consists of using a map in order to reduce the quantity of images.
>PS: this is a practice that we should consider more overall for all collectors in the future, as some images (kube-rbac-proxy for one) is used in multiple components and operators. WDYT?
>
>Fixes #OCPBUGS-33580
>
>## Type of change
>
>Please delete options that are not relevant.
>
>- [x] Bug fix (non-breaking change which fixes an issue)
>- [ ] New feature (non-breaking change which adds functionality)
>- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
>- [ ] This change requires a documentation update
>
># How Has This Been Tested?
>
>mirroring the following imagesetconfig with or without shortestPath: true should lead to the same number of mirrored images.
>```yaml
>kind: ImageSetConfiguration
>apiVersion: mirror.openshift.io/v2alpha1
>archiveSize: 8
>mirror:
> platform:
> channels:
> - name: stable-4.15
> type: ocp
> minVersion: '4.15.11'
> maxVersion: '4.15.11'
> shortestPath: true
>```
>
>## Expected Outcome
>Success
Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot]
lmzuccarelli
zhouying7780
openshift-bot
Description
When selecting the release nodes that correspond to the filtering, we were using a slice. duplicates nodes lead to mirroring the release content more than once. The fix consists of using a map in order to reduce the quantity of images. PS: this is a practice that we should consider more overall for all collectors in the future, as some images (kube-rbac-proxy for one) is used in multiple components and operators. WDYT?
Fixes #OCPBUGS-33580
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
mirroring the following imagesetconfig with or without shortestPath: true should lead to the same number of mirrored images.
Expected Outcome
Success