search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
82 stars 80 forks source link

OCPBUGS-31343: Display warning if package not found #857

Closed sherine-k closed 1 month ago

sherine-k commented 1 month ago

Description

Displays warnings if the operator package is not found in the catalog, but doesn't stop mirroring.

Fixes #OCPBUGS-31343

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Unit tests added.

Mirror to disk performed successfully with:

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
mirror:
  operators:
    - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15
      packages:
      - name: chocolate-factory-operator
      - name: external-dns-operator
      - name: aws-load-balancer-operator
        minVersion: "77.77.77"
        maxVersion: "77.77.99"

Expected Outcome

The above mirroring should show in logs:

2024/05/16 17:38:55  [INFO]   : 🔍 collecting operator images...
2024/05/16 17:39:02  [WARN]   : [OperatorImageCollector] package chocolate-factory-operator not found in catalog registry.redhat.io/redhat/redhat-operator-index:v4.15
2024/05/16 17:39:02  [WARN]   : [OperatorImageCollector] no bundles matching filtering for aws-load-balancer-operator in catalog registry.redhat.io/redhat/redhat-operator-index:v4.15
2024/05/16 17:39:02  [INFO]   : 🔍 collecting additional images...
2024/05/16 17:39:02  [INFO]   : 🚀 Start copying the images...
openshift-ci-robot commented 1 month ago

@sherine-k: This pull request references Jira Issue OCPBUGS-31343, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/857): ># Description >Displays warnings if the operator package is not found in the catalog, but doesn't stop mirroring. > >Fixes #OCPBUGS-31343 > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Unit tests added. > >Mirror to disk performed successfully with: >```yaml >kind: ImageSetConfiguration >apiVersion: mirror.openshift.io/v2alpha1 >mirror: > operators: > - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15 > packages: > - name: chocolate-factory-operator > - name: external-dns-operator > - name: aws-load-balancer-operator > minVersion: "77.77.77" > maxVersion: "77.77.99" >``` > >## Expected Outcome >The above mirroring should show in logs: >``` >2024/05/16 17:38:55 [INFO] : 🔍 collecting operator images... >2024/05/16 17:39:02 [WARN] : [OperatorImageCollector] package chocolate-factory-operator not found in catalog registry.redhat.io/redhat/redhat-operator-index:v4.15 >2024/05/16 17:39:02 [WARN] : [OperatorImageCollector] no bundles matching filtering for aws-load-balancer-operator in catalog registry.redhat.io/redhat/redhat-operator-index:v4.15 >2024/05/16 17:39:02 [INFO] : 🔍 collecting additional images... >2024/05/16 17:39:02 [INFO] : 🚀 Start copying the images... >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sherine-k commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@sherine-k: This pull request references Jira Issue OCPBUGS-31343, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc-mirror/pull/857#issuecomment-2115592305): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [sherine-k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zhouying7780 commented 1 month ago

/label qe-approved

openshift-ci-robot commented 1 month ago

@sherine-k: This pull request references Jira Issue OCPBUGS-31343, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/oc-mirror/pull/857): ># Description >Displays warnings if the operator package is not found in the catalog, but doesn't stop mirroring. > >Fixes #OCPBUGS-31343 > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Unit tests added. > >Mirror to disk performed successfully with: >```yaml >kind: ImageSetConfiguration >apiVersion: mirror.openshift.io/v2alpha1 >mirror: > operators: > - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15 > packages: > - name: chocolate-factory-operator > - name: external-dns-operator > - name: aws-load-balancer-operator > minVersion: "77.77.77" > maxVersion: "77.77.99" >``` > >## Expected Outcome >The above mirroring should show in logs: >``` >2024/05/16 17:38:55 [INFO] : 🔍 collecting operator images... >2024/05/16 17:39:02 [WARN] : [OperatorImageCollector] package chocolate-factory-operator not found in catalog registry.redhat.io/redhat/redhat-operator-index:v4.15 >2024/05/16 17:39:02 [WARN] : [OperatorImageCollector] no bundles matching filtering for aws-load-balancer-operator in catalog registry.redhat.io/redhat/redhat-operator-index:v4.15 >2024/05/16 17:39:02 [INFO] : 🔍 collecting additional images... >2024/05/16 17:39:02 [INFO] : 🚀 Start copying the images... >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lmzuccarelli commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@lmzuccarelli: This pull request references Jira Issue OCPBUGS-31343, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc-mirror/pull/857#issuecomment-2122490659): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lmzuccarelli commented 1 month ago

/lgtm

lmzuccarelli commented 1 month ago

/label acknowledge-critical-fixes-only

openshift-ci-robot commented 1 month ago

@sherine-k: Jira Issue OCPBUGS-31343: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31343 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/857): ># Description >Displays warnings if the operator package is not found in the catalog, but doesn't stop mirroring. > >Fixes #OCPBUGS-31343 > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Unit tests added. > >Mirror to disk performed successfully with: >```yaml >kind: ImageSetConfiguration >apiVersion: mirror.openshift.io/v2alpha1 >mirror: > operators: > - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15 > packages: > - name: chocolate-factory-operator > - name: external-dns-operator > - name: aws-load-balancer-operator > minVersion: "77.77.77" > maxVersion: "77.77.99" >``` > >## Expected Outcome >The above mirroring should show in logs: >``` >2024/05/16 17:38:55 [INFO] : 🔍 collecting operator images... >2024/05/16 17:39:02 [WARN] : [OperatorImageCollector] package chocolate-factory-operator not found in catalog registry.redhat.io/redhat/redhat-operator-index:v4.15 >2024/05/16 17:39:02 [WARN] : [OperatorImageCollector] no bundles matching filtering for aws-load-balancer-operator in catalog registry.redhat.io/redhat/redhat-operator-index:v4.15 >2024/05/16 17:39:02 [INFO] : 🔍 collecting additional images... >2024/05/16 17:39:02 [INFO] : 🚀 Start copying the images... >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.17.0-202405211341.p0.g746fddf.assembly.stream.el9 for distgit oc-mirror-plugin. All builds following this will include this PR.