search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
82 stars 80 forks source link

OCPBUGS-34021: Activate flags for timeout, retry and maxParallelDownload #858

Closed sherine-k closed 1 month ago

sherine-k commented 1 month ago

Description

This PR activates the following containers/image flags in order to help reduce errors during mirroring.

Fixes # OCPBUGS-34021

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

E2E and unit tests pass.

Expected Outcome

This will take some manual testing to actually be able to see the various flags in action.

openshift-ci-robot commented 1 month ago

@sherine-k: This pull request references Jira Issue OCPBUGS-34021, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/858): ># Description > >This PR activates the following `containers/image` flags in order to help reduce errors during mirroring. >- `--retry-times`: the number of times to possibly retry. default is 2. >- `--retry-delay`: delay between 2 retries. Default 1s >- `--image-timeout` : Timeout for mirroring an image. Defaults to 10mn >- `--max-parallel-downloads` : the maximum layers to pull at the same time. Applies to a single copy operation.. Default to 6 > > >Fixes # OCPBUGS-34021 > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? >E2E and unit tests pass. > >## Expected Outcome >This will take some manual testing to actually be able to see the various flags in action. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [sherine-k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhouying7780 commented 1 month ago

/label qe-approved

openshift-ci-robot commented 1 month ago

@sherine-k: This pull request references Jira Issue OCPBUGS-34021, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc-mirror/pull/858): ># Description > >This PR activates the following `containers/image` flags in order to help reduce errors during mirroring. >- `--retry-times`: the number of times to possibly retry. default is 2. >- `--retry-delay`: delay between 2 retries. Default 1s >- `--image-timeout` : Timeout for mirroring an image. Defaults to 10mn >- `--max-parallel-downloads` : the maximum layers to pull at the same time. Applies to a single copy operation.. Default to 6 > > >Fixes # OCPBUGS-34021 > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? >E2E and unit tests pass. > >## Expected Outcome >This will take some manual testing to actually be able to see the various flags in action. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lmzuccarelli commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@sherine-k: Jira Issue OCPBUGS-34021: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34021 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/858): ># Description > >This PR activates the following `containers/image` flags in order to help reduce errors during mirroring. >- `--retry-times`: the number of times to possibly retry. default is 2. >- `--retry-delay`: delay between 2 retries. Default 1s >- `--image-timeout` : Timeout for mirroring an image. Defaults to 10mn >- `--max-parallel-downloads` : the maximum layers to pull at the same time. Applies to a single copy operation.. Default to 6 > > >Fixes # OCPBUGS-34021 > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? >E2E and unit tests pass. > >## Expected Outcome >This will take some manual testing to actually be able to see the various flags in action. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.17.0-202405291241.p0.gbd77b7b.assembly.stream.el9 for distgit oc-mirror-plugin. All builds following this will include this PR.