search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
82 stars 80 forks source link

OCPBUGS-34211: docker.io registry/2 is pulled with a platform argument #859

Closed prb112 closed 1 month ago

prb112 commented 1 month ago

Description

Fixes # https://issues.redhat.com/browse/OCPBUGS-34211

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run on Z

Expected Outcome

e2e tests run on z/power

openshift-ci-robot commented 1 month ago

@prb112: This pull request references Jira Issue OCPBUGS-34211, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/859): ># Description > >- docker.io updated to a manifest listed image. >- the code accounts for this change. > >Fixes # https://issues.redhat.com/browse/OCPBUGS-34211 > >## Type of change >Bug fix (non-breaking change which fixes an issue) > ># How Has This Been Tested? > >Run on Z > >## Expected Outcome >e2e tests run on z/power Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
prb112 commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@prb112: This pull request references Jira Issue OCPBUGS-34211, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (smottika@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/oc-mirror/pull/859#issuecomment-2128252422): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lmzuccarelli commented 1 month ago

/lgtm

lmzuccarelli commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmzuccarelli, prb112

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [lmzuccarelli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lmzuccarelli commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

@prb112: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@prb112: Jira Issue OCPBUGS-34211: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34211 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/859): ># Description > >- docker.io updated to a manifest listed image. >- the code accounts for this change. > >Fixes # https://issues.redhat.com/browse/OCPBUGS-34211 > >## Type of change >Bug fix (non-breaking change which fixes an issue) > ># How Has This Been Tested? > >Run on Z > >## Expected Outcome >e2e tests run on z/power Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.17.0-202405301713.p0.gb8a0ffa.assembly.stream.el9 for distgit oc-mirror-plugin. All builds following this will include this PR.