search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
82 stars 80 forks source link

CLID-122,OCPBUGS-34948: upgrades distribution/distribution for a released version #864

Closed aguidirh closed 1 month ago

aguidirh commented 1 month ago

Description

This PR upgrades the distribution/distribution to a version released in github (v3.0.0-alpha.1) which is the one recommended by the maintainers.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

MirrorToMirror, MirrorToDisk and DiskToMirror on v2

It is necessary to still run the basic flows on v1.

Expected Outcome

All the flows should finish successfully.

openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-122 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/oc-mirror/pull/864): ># Description > >This PR upgrades the distribution/distribution to a version released in github (v3.0.0-alpha.1) [which is the one recommended by the maintainers](https://github.com/distribution/distribution/discussions/4317#discussioncomment-8973790). > >## Type of change > >Please delete options that are not relevant. > >- [X] Bug fix (non-breaking change which fixes CVEs) > ># How Has This Been Tested? > >MirrorToMirror, MirrorToDisk and DiskToMirror on v2 > >It is necessary to still run the basic flows on v1. > >## Expected Outcome > >All the flows should finish successfully. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [aguidirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-122 which is a valid jira issue.

In response to [this](https://github.com/openshift/oc-mirror/pull/864): ># Description > >This PR upgrades the distribution/distribution to a version released in github [v3.0.0-alpha.1](https://github.com/distribution/distribution/releases/tag/v3.0.0-alpha.1) [which is the one recommended by the maintainers](https://github.com/distribution/distribution/discussions/4317#discussioncomment-8973790). > >## Type of change > >Please delete options that are not relevant. > >- [X] Bug fix (non-breaking change which fixes CVEs) > ># How Has This Been Tested? > >MirrorToMirror, MirrorToDisk and DiskToMirror on v2 > >It is necessary to still run the basic flows on v1. > >## Expected Outcome > >All the flows should finish successfully. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-122 which is a valid jira issue.

In response to [this](https://github.com/openshift/oc-mirror/pull/864): ># Description > >This PR upgrades the distribution/distribution to a version released in github ([v3.0.0-alpha.1](https://github.com/distribution/distribution/releases/tag/v3.0.0-alpha.1)) [which is the one recommended by the maintainers](https://github.com/distribution/distribution/discussions/4317#discussioncomment-8973790). > >## Type of change > >Please delete options that are not relevant. > >- [X] Bug fix (non-breaking change which fixes CVEs) > ># How Has This Been Tested? > >MirrorToMirror, MirrorToDisk and DiskToMirror on v2 > >It is necessary to still run the basic flows on v1. > >## Expected Outcome > >All the flows should finish successfully. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@aguidirh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
lmzuccarelli commented 1 month ago

@aguidirh - Thanks for updating this for us. Just out of curiosity where you able to re-create the hanging problem with this version ?

aguidirh commented 1 month ago

@lmzuccarelli the tests I did the hang issue did not happen. But as you know this issue does not happen always so maybe it is still there.

aguidirh commented 1 month ago

@kasturinarra and @zhouying7780 could you please test to see if there is no regression on v1? I tested only v2 flows.

lmzuccarelli commented 1 month ago

from my side it looks good (all tests are passing) - lets wait for QE to report on regressions

sherine-k commented 1 month ago

LGTM for me as well :+1: Curious to learn more from your explanation on how to setup the registry log (it does look easier than before).

sherine-k commented 1 month ago

/lgtm

aguidirh commented 1 month ago

/cherrypick release-4.16

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.17.0-202406041111.p0.g765d94b.assembly.stream.el9 for distgit oc-mirror-plugin. All builds following this will include this PR.

aguidirh commented 1 month ago

/cherrypick release-4.16

aguidirh commented 1 month ago

/cherry-pick release-4.16

openshift-ci-robot commented 1 month ago

@aguidirh: Jira Issue OCPBUGS-34948: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34948 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/864): ># Description > >This PR upgrades the distribution/distribution to a version released in github ([v3.0.0-alpha.1](https://github.com/distribution/distribution/releases/tag/v3.0.0-alpha.1)) [which is the one recommended by the maintainers](https://github.com/distribution/distribution/discussions/4317#discussioncomment-8973790). > >## Type of change > >Please delete options that are not relevant. > >- [X] Bug fix (non-breaking change which fixes CVEs) > ># How Has This Been Tested? > >MirrorToMirror, MirrorToDisk and DiskToMirror on v2 > >It is necessary to still run the basic flows on v1. > >## Expected Outcome > >All the flows should finish successfully. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.