search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
88 stars 80 forks source link

OCPBUGS-33121: Fix problems with versions and verbose flags #867

Closed lmzuccarelli closed 3 months ago

lmzuccarelli commented 3 months ago

Description

This fix addresses the issue faced in using the --v2 (used to invoke v2 of oc mirror) and accidentally using -v2 (used for verbose logging)

This fix will only be for 4.17 onwards until we deprecate v1

Fixes # OCPBUGS-33121

Type of change

How Has This Been Tested?

Locally and unit tests

Expected Outcome

console message should show 

error: detected a v2 ImageSetConfiguration, please use --v2 instead of -v2
openshift-ci-robot commented 3 months ago

@lmzuccarelli: This pull request references Jira Issue OCPBUGS-33121, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/867): ># Description > >This fix addresses the issue faced in using the --v2 (used to invoke v2 of oc mirro) and accidentally using -v2 (used for verbose logging) > >Fixes # OCPBUGS-33121 > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Locally and unit tests > >## Expected Outcome >Should not allow the user to use -v2 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmzuccarelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [lmzuccarelli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

@lmzuccarelli: This pull request references Jira Issue OCPBUGS-33121, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc-mirror/pull/867): ># Description > >This fix addresses the issue faced in using the --v2 (used to invoke v2 of oc mirror) and accidentally using -v2 (used for verbose logging) > >Fixes # OCPBUGS-33121 > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Locally and unit tests > >## Expected Outcome >Should not allow the user to use -v2 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lmzuccarelli commented 3 months ago

/retest

aguidirh commented 3 months ago

Usually before removing flags on GA version of oc-mirror like v1, it is necessary to deprecate them and let the customers know in the docs they need to remove the flag from their automatons / scripts. It gives them time to change their side.

Removing flags directly without deprecating could cause breaking automation which uses the flag removed.

Suggestion:

-Based on the apiVersion of the image set configuration (v2alpha1 for example) it would be possible to identify that the customer wants to use v2 and print a message the correct flag is --v2 and not -v2 and stop the flow so the customer can fix the mistake.

lmzuccarelli commented 3 months ago

/test unit

openshift-ci[bot] commented 3 months ago

@lmzuccarelli: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sherine-k commented 3 months ago

/lgtm

openshift-ci-robot commented 3 months ago

@lmzuccarelli: Jira Issue OCPBUGS-33121: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33121 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/867): ># Description > >This fix addresses the issue faced in using the --v2 (used to invoke v2 of oc mirror) and accidentally using -v2 (used for verbose logging) > >This fix will only be for 4.17 onwards until we deprecate v1 > >Fixes # OCPBUGS-33121 > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Locally and unit tests > >## Expected Outcome >console message should show > >``` >error: detected a v2 ImageSetConfiguration, please use --v2 instead of -v2 >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.17.0-202406052200.p0.ge164546.assembly.stream.el9 for distgit oc-mirror-plugin. All builds following this will include this PR.