search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
82 stars 80 forks source link

[release-4.16] CLID-138,OCPBUGS-34947: upgrades distribution/distribution for a released version #868

Closed aguidirh closed 1 month ago

aguidirh commented 1 month ago

Description

Cherry-pich of #864

This PR upgrades the distribution/distribution to a version released in github (v3.0.0-alpha.1) which is the one recommended by the maintainers.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

MirrorToMirror, MirrorToDisk and DiskToMirror on v2

It is necessary to still run the basic flows on v1.

Expected Outcome

All the flows should finish successfully.

openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.17" instead.

In response to [this](https://github.com/openshift/oc-mirror/pull/868): ># Description > >Cherry-pich of [#864](https://github.com/openshift/oc-mirror/pull/864) > >This PR upgrades the distribution/distribution to a version released in github ([v3.0.0-alpha.1](https://github.com/distribution/distribution/releases/tag/v3.0.0-alpha.1)) [which is the one recommended by the maintainers](https://github.com/distribution/distribution/discussions/4317#discussioncomment-8973790). > >## Type of change > >Please delete options that are not relevant. > >- [X] Bug fix (non-breaking change which fixes CVEs) > ># How Has This Been Tested? > >MirrorToMirror, MirrorToDisk and DiskToMirror on v2 > >It is necessary to still run the basic flows on v1. > >## Expected Outcome > >All the flows should finish successfully. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/release-4.16/OWNERS)~~ [aguidirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@aguidirh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
lmzuccarelli commented 1 month ago

@aguidirh - would you mind adding [release-4.16] in the title - makes it less confusing. Thanks

zhouying7780 commented 1 month ago

/label qe-approved

openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.17" instead.

In response to [this](https://github.com/openshift/oc-mirror/pull/868): ># Description > >Cherry-pich of [#864](https://github.com/openshift/oc-mirror/pull/864) > >This PR upgrades the distribution/distribution to a version released in github ([v3.0.0-alpha.1](https://github.com/distribution/distribution/releases/tag/v3.0.0-alpha.1)) [which is the one recommended by the maintainers](https://github.com/distribution/distribution/discussions/4317#discussioncomment-8973790). > >## Type of change > >Please delete options that are not relevant. > >- [X] Bug fix (non-breaking change which fixes CVEs) > ># How Has This Been Tested? > >MirrorToMirror, MirrorToDisk and DiskToMirror on v2 > >It is necessary to still run the basic flows on v1. > >## Expected Outcome > >All the flows should finish successfully. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zhouying7780 commented 1 month ago

/label cherry-pick-approved

aguidirh commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-138 which is a valid jira issue.

In response to [this](https://github.com/openshift/oc-mirror/pull/868#issuecomment-2150082772): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sherine-k commented 1 month ago

/lgtm

sherine-k commented 1 month ago

/retitle [release-4.16] CLID-138: upgrades distribution/distribution for a released version

aguidirh commented 1 month ago

@aguidirh - would you mind adding [release-4.16] in the title - makes it less confusing. Thanks

Done @lmzuccarelli

openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-138 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-34947, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/868): ># Description > >Cherry-pich of [#864](https://github.com/openshift/oc-mirror/pull/864) > >This PR upgrades the distribution/distribution to a version released in github ([v3.0.0-alpha.1](https://github.com/distribution/distribution/releases/tag/v3.0.0-alpha.1)) [which is the one recommended by the maintainers](https://github.com/distribution/distribution/discussions/4317#discussioncomment-8973790). > >## Type of change > >Please delete options that are not relevant. > >- [X] Bug fix (non-breaking change which fixes CVEs) > ># How Has This Been Tested? > >MirrorToMirror, MirrorToDisk and DiskToMirror on v2 > >It is necessary to still run the basic flows on v1. > >## Expected Outcome > >All the flows should finish successfully. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aguidirh commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-138 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-34947, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/oc-mirror/pull/868#issuecomment-2150111265): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aguidirh commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-138 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-34947, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/oc-mirror/pull/868#issuecomment-2150118881): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aguidirh commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@aguidirh: This pull request references CLID-138 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-34947, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-34948](https://issues.redhat.com//browse/OCPBUGS-34948) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-34948](https://issues.redhat.com//browse/OCPBUGS-34948) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc-mirror/pull/868#issuecomment-2150137744): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sherine-k commented 1 month ago

/label backport-risk-assessed

openshift-ci-robot commented 1 month ago

@aguidirh: Jira Issue OCPBUGS-34947: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34947 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/868): ># Description > >Cherry-pich of [#864](https://github.com/openshift/oc-mirror/pull/864) > >This PR upgrades the distribution/distribution to a version released in github ([v3.0.0-alpha.1](https://github.com/distribution/distribution/releases/tag/v3.0.0-alpha.1)) [which is the one recommended by the maintainers](https://github.com/distribution/distribution/discussions/4317#discussioncomment-8973790). > >## Type of change > >Please delete options that are not relevant. > >- [X] Bug fix (non-breaking change which fixes CVEs) > ># How Has This Been Tested? > >MirrorToMirror, MirrorToDisk and DiskToMirror on v2 > >It is necessary to still run the basic flows on v1. > >## Expected Outcome > >All the flows should finish successfully. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.16.0-202406052235.p0.gc6cad79.assembly.stream.el9 for distgit oc-mirror-plugin. All builds following this will include this PR.