search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
82 stars 80 forks source link

OCPBUGS-33775: Do not generate idms & itms if nothing has been mirrored #869

Closed sherine-k closed 4 weeks ago

sherine-k commented 1 month ago

Description

This PR skips the generation of an empty itms/idms/catalogsource when no images corresponding are available.

Fixes #OCPBUGS-33775

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Using this imagesetconfiguration, only itms is generated

kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v2alpha1
mirror:
  # operators:
  # - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15
  #   targetCatalog: hij/redhat-operator-index
  #   packages:
  #   - name: aws-load-balancer-operator
  additionalImages:
  - name: registry.redhat.io/ubi8/ubi:latest

Expected Outcome

idms file is not generated

openshift-ci-robot commented 1 month ago

@sherine-k: This pull request references Jira Issue OCPBUGS-33775, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/869): ># Description > >This PR skips the generation of an empty itms/idms/catalogsource when no images corresponding are available. > >Fixes #OCPBUGS-33775 > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? >Using this imagesetconfiguration, only itms is generated >```yaml >kind: ImageSetConfiguration >apiVersion: mirror.openshift.io/v2alpha1 >mirror: > # operators: > # - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15 > # targetCatalog: hij/redhat-operator-index > # packages: > # - name: aws-load-balancer-operator > additionalImages: > - name: registry.redhat.io/ubi8/ubi:latest > ``` > >## Expected Outcome >idms file is not generated Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sherine-k commented 1 month ago

/cherrypick release-4.16

openshift-cherrypick-robot commented 1 month ago

@sherine-k: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/oc-mirror/pull/869#issuecomment-2150006222): >/cherrypick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [sherine-k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sherine-k commented 4 weeks ago

/retest

aguidirh commented 4 weeks ago

/lgtm

openshift-ci-robot commented 4 weeks ago

/retest-required

Remaining retests: 0 against base HEAD e16454664d69ca4052e79ccb193e492109d80019 and 2 for PR HEAD d2a257c5b4be568eed83024ad5bc926f774455ee in total

openshift-ci[bot] commented 4 weeks ago

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 weeks ago

@sherine-k: Jira Issue OCPBUGS-33775: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33775 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/869): ># Description > >This PR skips the generation of an empty itms/idms/catalogsource when no images corresponding are available. > >Fixes #OCPBUGS-33775 > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? >Using this imagesetconfiguration, only itms is generated >```yaml >kind: ImageSetConfiguration >apiVersion: mirror.openshift.io/v2alpha1 >mirror: > # operators: > # - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15 > # targetCatalog: hij/redhat-operator-index > # packages: > # - name: aws-load-balancer-operator > additionalImages: > - name: registry.redhat.io/ubi8/ubi:latest > ``` > >## Expected Outcome >idms file is not generated Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 4 weeks ago

@sherine-k: new pull request created: #871

In response to [this](https://github.com/openshift/oc-mirror/pull/869#issuecomment-2150006222): >/cherrypick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 4 weeks ago

[ART PR BUILD NOTIFIER]

This PR has been included in build oc-mirror-plugin-container-v4.17.0-202406061914.p0.g82878a9.assembly.stream.el9 for distgit oc-mirror-plugin. All builds following this will include this PR.