search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
82 stars 80 forks source link

[release-4.16] OCPBUGS-35409: Implement fail safe / fail fast in workers #879

Closed openshift-cherrypick-robot closed 1 week ago

openshift-cherrypick-robot commented 3 weeks ago

This is an automated cherry-pick of #865

/assign sherine-k

openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-34020 has been cloned as Jira Issue OCPBUGS-35409. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-35409: Implement fail safe / fail fast in workers

In response to [this](https://github.com/openshift/oc-mirror/pull/879): >This is an automated cherry-pick of #865 > >/assign sherine-k Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35409, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/879): >This is an automated cherry-pick of #865 > >/assign sherine-k Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 weeks ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sherine-k commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@sherine-k: This pull request references Jira Issue OCPBUGS-35409, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-34020](https://issues.redhat.com//browse/OCPBUGS-34020) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-34020](https://issues.redhat.com//browse/OCPBUGS-34020) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @kasturinarra

In response to [this](https://github.com/openshift/oc-mirror/pull/879#issuecomment-2167320962): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
kasturinarra commented 3 weeks ago

/lgtm

kasturinarra commented 3 weeks ago

/label qe-approved

openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35409, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-34020](https://issues.redhat.com//browse/OCPBUGS-34020) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-34020](https://issues.redhat.com//browse/OCPBUGS-34020) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @kasturinarra

In response to [this](https://github.com/openshift/oc-mirror/pull/879): >This is an automated cherry-pick of #865 > >/assign sherine-k Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aguidirh commented 2 weeks ago

/approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/release-4.16/OWNERS)~~ [aguidirh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lmzuccarelli commented 2 weeks ago

/label backport-risk-assessed

sherine-k commented 2 weeks ago

/label backport-risk-assessed

kasturinarra commented 2 weeks ago

/label cherry-pick-approved

aguidirh commented 2 weeks ago

@zaneb could you please have a look and if everything is fine give staff-eng-approved to this PR?

zaneb commented 2 weeks ago

As discussed, not applying staff-eng-approved as this is not a release blocker. The label requirement will be lifted after GA and this can land in an early z-stream.

openshift-ci-robot commented 1 week ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35409: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35409 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/879): >This is an automated cherry-pick of #865 > >/assign sherine-k Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-merge-robot commented 4 days ago

Fix included in accepted release 4.16.0-0.nightly-2024-07-01-133841