search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
91 stars 82 forks source link

CLID-232,OCPBUGS-38339,OCPBUGS-38343,OCPBUGS-38233: Create release signature configmap #924

Closed lmzuccarelli closed 2 months ago

lmzuccarelli commented 2 months ago

Description

Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror

This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343

Type of change

How Has This Been Tested?

Use the following imagesetconfig 

apiVersion: mirror.openshift.io/v2alpha1
kind: ImageSetConfiguration
mirror:
  platform:
    channels:
    - name: stable-4.16
      minVersion: 4.16.0
      maxVersion: 4.16.0

Execute oc-mirror mirror to disk workflow

bin/oc-mirror --config clid-232.yaml file://clid-232 --v2

Now execute the disk to mirror workflow 

bin/oc-mirror --config clid-232.yaml --from file://clid-232  docker://localhost:5000/clid-232 --v2 --tls-verify=false

Expected Outcome

Check the working-dir/cluster-resources folder there should be a files with naming convention signature-configmap.json and signature-configmap.yaml

To verify the contents of this field execute the following bash cli The working-dir/signatures/ folder has the same digest

cat working-dir/signatures/4.16.0-x86_64-sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64

The value output should match the contents of the config map (BinaryData section)

Verify the bug fixes

OCPBUGS-38339

In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message

OCPBUGS-38343

Once the disk-to-mirror workflow has been executed , verify that here should be both json and yaml files (with configmap structure) in the directory "working-dir/cluster-resources"

OCPBUGS-38233

Once the disk-to-mirror workflow has been executed , verify that here should be both json and yaml files (with configmap structure) in the directory "working-dir/cluster-resources"

openshift-ci-robot commented 2 months ago

@lmzuccarelli: This pull request references CLID-232 which is a valid jira issue.

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > > >## Type of change > >- [ ] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a file with naming convention ``` sha256-digest-id.json``` > >(in the above example I get) > >``` sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3-1.json ``` > >Also ensure the contents of the configmap json has a binary data field with and index in the form of the file name (without the ".json") > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lmzuccarelli commented 2 months ago

/retest

openshift-ci-robot commented 2 months ago

@lmzuccarelli: This pull request references CLID-232 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-38339, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-38343, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > > >## Type of change > >- [ ] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a file with naming convention ``` sha256-digest-id.json``` > >(in the above example I get) > >``` sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3-1.json ``` > >Also ensure the contents of the configmap json has a binary data field with and index in the form of the file name (without the ".json") > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@lmzuccarelli: This pull request references CLID-232 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-38339, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

This pull request references Jira Issue OCPBUGS-38343, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > >This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343 > > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a file with naming convention ``` sha256-digest-id.json``` > >(in the above example I get) > >``` sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3-1.json ``` > >Also ensure the contents of the configmap json has a binary data field with and index in the form of the file name (without the ".json") > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map > >Verify the bug fixes > >OCPBUGS-38339 > >In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message > >OCPBUGS-38343 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a json file (with configmap structure) in the directory "working-dir/cluster-reousrces" > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@lmzuccarelli: This pull request references CLID-232 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-38339, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

This pull request references Jira Issue OCPBUGS-38343, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > >This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343 > > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a file with naming convention ``` sha256-digest-id.json``` > >(in the above example I get) > >``` sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3-1.json ``` > >Also ensure the contents of the configmap json has a binary data field with and index in the form of the file name (without the ".json") > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map > >Verify the bug fixes > >OCPBUGS-38339 > >In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message > >OCPBUGS-38343 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a json file (with configmap structure) in the directory "working-dir/cluster-resources" > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@lmzuccarelli: This pull request references CLID-232 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-38339, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-38343, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-38233, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > >This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343 > > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a file with naming convention ``` sha256-digest-id.json``` > >(in the above example I get) > >``` sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3-1.json ``` > >Also ensure the contents of the configmap json has a binary data field with and index in the form of the file name (without the ".json") > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map > >Verify the bug fixes > >OCPBUGS-38339 > >In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message > >OCPBUGS-38343 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a json file (with configmap structure) in the directory "working-dir/cluster-resources" > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@lmzuccarelli: This pull request references CLID-232 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-38339, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

This pull request references Jira Issue OCPBUGS-38343, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

This pull request references Jira Issue OCPBUGS-38233, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > >This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343 > > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a file with naming convention ``` sha256-digest-id.json``` > >(in the above example I get) > >``` sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3-1.json ``` > >Also ensure the contents of the configmap json has a binary data field with and index in the form of the file name (without the ".json") > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map > >Verify the bug fixes > >OCPBUGS-38339 > >In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message > >OCPBUGS-38343 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a json file (with configmap structure in json) in the directory "working-dir/cluster-resources" > >OCPBUGS-38233 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a yaml file (with configmap structure in yaml format) in the directory "working-dir/cluster-resources" > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lmzuccarelli commented 2 months ago

/hold

lmzuccarelli commented 2 months ago

/unhold

openshift-ci-robot commented 2 months ago

@lmzuccarelli: This pull request references CLID-232 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-38339, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

This pull request references Jira Issue OCPBUGS-38343, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

This pull request references Jira Issue OCPBUGS-38233, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > >This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343 > > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` >Now execute the disk to mirror workflow > >```bash >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml --from file://clid-232 docker://localhost:5000/clid-232 --v2 --tls-verify=false >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a file with naming convention ``` sha256-digest-id.json``` > >(in the above example I get) > >``` sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3-1.json ``` > >Also ensure the contents of the configmap json has a binary data field with and index in the form of the file name (without the ".json") > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map > >Verify the bug fixes > >OCPBUGS-38339 > >In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message > >OCPBUGS-38343 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a json file (with configmap structure in json) in the directory "working-dir/cluster-resources" > >OCPBUGS-38233 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a yaml file (with configmap structure in yaml format) in the directory "working-dir/cluster-resources" > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@lmzuccarelli: This pull request references CLID-232 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-38339, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

This pull request references Jira Issue OCPBUGS-38343, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

This pull request references Jira Issue OCPBUGS-38233, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > >This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343 > > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` >Now execute the disk to mirror workflow > >```bash >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml --from file://clid-232 docker://localhost:5000/clid-232 --v2 --tls-verify=false >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a file with naming convention ``` sha256-digest-id.json``` > >(in the above example I get) > >``` sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3-1.json ``` > >Also ensure the contents of the configmap json has a binary data field with and index in the form of the file name (without the ".json") > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/4.16.0-x86_64-sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map (BinaryData section) > >Verify the bug fixes > >OCPBUGS-38339 > >In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message > >OCPBUGS-38343 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a json file (with configmap structure in json) in the directory "working-dir/cluster-resources" > >OCPBUGS-38233 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a yaml file (with configmap structure in yaml format) in the directory "working-dir/cluster-resources" > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@lmzuccarelli: This pull request references CLID-232 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-38339, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

This pull request references Jira Issue OCPBUGS-38343, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

This pull request references Jira Issue OCPBUGS-38233, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > >This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343 > > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror mirror to disk workflow > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` >Now execute the disk to mirror workflow > >```bash >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml --from file://clid-232 docker://localhost:5000/clid-232 --v2 --tls-verify=false >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a file with naming convention ``` sha256-digest-id.json``` > >(in the above example I get) > >``` sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3-1.json ``` > >Also ensure the contents of the configmap json has a binary data field with and index in the form of the file name (without the ".json") > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/4.16.0-x86_64-sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map (BinaryData section) > >Verify the bug fixes > >OCPBUGS-38339 > >In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message > >OCPBUGS-38343 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a json file (with configmap structure in json) in the directory "working-dir/cluster-resources" > >OCPBUGS-38233 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a yaml file (with configmap structure in yaml format) in the directory "working-dir/cluster-resources" > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@lmzuccarelli: This pull request references CLID-232 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-38339, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

This pull request references Jira Issue OCPBUGS-38343, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

This pull request references Jira Issue OCPBUGS-38233, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > >This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343 > > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror mirror to disk workflow > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` >Now execute the disk to mirror workflow > >```bash >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml --from file://clid-232 docker://localhost:5000/clid-232 --v2 --tls-verify=false >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a files with naming convention ``` signature-configmap.json and signature-configmap.yaml``` > >(in the above example I get) > >``` sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3-1.json ``` > >Also ensure the contents of the configmap json has a binary data field with and index in the form of the file name (without the ".json") > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/4.16.0-x86_64-sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map (BinaryData section) > >Verify the bug fixes > >OCPBUGS-38339 > >In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message > >OCPBUGS-38343 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a json file (with configmap structure in json) in the directory "working-dir/cluster-resources" > >OCPBUGS-38233 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a yaml file (with configmap structure in yaml format) in the directory "working-dir/cluster-resources" > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@lmzuccarelli: This pull request references CLID-232 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-38339, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

This pull request references Jira Issue OCPBUGS-38343, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

This pull request references Jira Issue OCPBUGS-38233, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @kasturinarra

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > >This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343 > > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror mirror to disk workflow > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` >Now execute the disk to mirror workflow > >```bash >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml --from file://clid-232 docker://localhost:5000/clid-232 --v2 --tls-verify=false >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a files with naming convention ``` signature-configmap.json and signature-configmap.yaml``` > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/4.16.0-x86_64-sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map (BinaryData section) > >Verify the bug fixes > >OCPBUGS-38339 > >In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message > >OCPBUGS-38343 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a json file (with configmap structure in json) in the directory "working-dir/cluster-resources" > >OCPBUGS-38233 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a yaml file (with configmap structure in yaml format) in the directory "working-dir/cluster-resources" > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
kasturinarra commented 2 months ago

Completed testing CLID-232 and found two issues, listing the same here:

  1. After d2m the folder path shown for signature configmap is missing a / see here 024/09/20 11:39:57 [INFO] : [CLID-232](https://issues.redhat.com//browse/CLID-232)/working-dir/cluster-resourcessignature-configmap.json file created, 2024/09/20 11:39:57 [INFO] : [CLID-232](https://issues.redhat.com//browse/CLID-232)/working-dir/cluster-resourcessignature-configmap.yaml file created -> this looks to me as bug
  2. Binary data contains sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3-1: only after that it contains the actual content when run cat working-dir/signatures/4.16.0-x86_64-sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 and base64 also contains a = at the end cc: @lmzuccarelli
lmzuccarelli commented 2 months ago

@kasturinarra - thanks for the feedback , I'll update and fix asap.

lmzuccarelli commented 2 months ago

@kasturinarra - I have updated as requested and addressed the version-arch prefix problem

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmzuccarelli, sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [lmzuccarelli,sherine-k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aguidirh commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

@lmzuccarelli: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@lmzuccarelli: Jira Issue OCPBUGS-38339: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38339 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-38343: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38343 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-38233: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38233 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > >This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343 > > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror mirror to disk workflow > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` >Now execute the disk to mirror workflow > >```bash >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml --from file://clid-232 docker://localhost:5000/clid-232 --v2 --tls-verify=false >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a files with naming convention ``` signature-configmap.json and signature-configmap.yaml``` > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/4.16.0-x86_64-sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map (BinaryData section) > >Verify the bug fixes > >OCPBUGS-38339 > >In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message > >OCPBUGS-38343 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a json file (with configmap structure in json) in the directory "working-dir/cluster-resources" > >OCPBUGS-38233 > >Once the tar file has been produced in the (mirror-to-disk) workflow, untar the contents and there should be a yaml file (with configmap structure in yaml format) in the directory "working-dir/cluster-resources" > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: oc-mirror-plugin This PR has been included in build oc-mirror-plugin-container-v4.18.0-202409231040.p0.ga5a32fa.assembly.stream.el9. All builds following this will include this PR.

openshift-ci-robot commented 1 month ago

@lmzuccarelli: Jira Issue OCPBUGS-38339 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Jira Issue OCPBUGS-38343: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38343 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-38233 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/924): ># Description > >Add the release signature configmap for oc-mirror v2 (json format compatible with v1) to the cluster-resources folder of oc-mirror > >This fix also addresses the bug fixes for OCPBUGS-38339 and OCPBUGS-38343 > > >## Type of change > >- [x] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Use the following imagesetconfig > >``` >apiVersion: mirror.openshift.io/v2alpha1 >kind: ImageSetConfiguration >mirror: > platform: > channels: > - name: stable-4.16 > minVersion: 4.16.0 > maxVersion: 4.16.0 >``` > >Execute oc-mirror mirror to disk workflow > >``` >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml file://clid-232 --v2 >``` >Now execute the disk to mirror workflow > >```bash >bin/oc-mirror --config [clid-232](https://issues.redhat.com//browse/clid-232).yaml --from file://clid-232 docker://localhost:5000/clid-232 --v2 --tls-verify=false >``` > >## Expected Outcome >Check the working-dir/cluster-resources folder there should be a files with naming convention ``` signature-configmap.json and signature-configmap.yaml``` > >To verify the contents of this field execute the following bash cli The ``` working-dir/signatures/ ``` folder has the same digest > >``` >cat working-dir/signatures/4.16.0-x86_64-sha256-3717338045df06e31effea46761b2c7e90f543cc4f00547af8158dd6aea868c3 | base64 >``` > >The value output should match the contents of the config map (BinaryData section) > >Verify the bug fixes > >OCPBUGS-38339 > >In the jira ticket follow the steps to re-produce the bug, there should be no panic but an error with appropriate message > >OCPBUGS-38343 > >Once the disk-to-mirror workflow has been executed , verify that here should be both json and yaml files (with configmap structure) in the directory "working-dir/cluster-resources" > >OCPBUGS-38233 > >Once the disk-to-mirror workflow has been executed , verify that here should be both json and yaml files (with configmap structure) in the directory "working-dir/cluster-resources" > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.