search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
91 stars 82 forks source link

CLID-263: redirects the rebuild error to a rebuild-error.log #949

Closed aguidirh closed 2 weeks ago

aguidirh commented 2 weeks ago

Description

The code in this PR adds a rebuild-error.log to help during troubleshooting when errors happen during the rebuild of catalog phase.

Fixes CLID-263

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

An invalid container file was provided in the rebuild_catalog.go

Expected Outcome

The rebuild-error.log must contain information about the error.

openshift-ci-robot commented 2 weeks ago

@aguidirh: This pull request references CLID-263 which is a valid jira issue.

In response to [this](https://github.com/openshift/oc-mirror/pull/949): ># Description > >The code in this PR adds a rebuild-error.log to help during troubleshooting when errors happen during the rebuild of catalog phase. > >Fixes [CLID-263](https://issues.redhat.com/browse/CLID-263) > >## Type of change > >Please delete options that are not relevant. > >- [ ] Bug fix (non-breaking change which fixes an issue) >- [x] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >An invalid container file was provided in the rebuild_catalog.go > >## Expected Outcome > >The rebuild-error.log must contain information about the error. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

@aguidirh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aguidirh, sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [aguidirh,sherine-k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lmzuccarelli commented 2 weeks ago

/lgtm