search

openshift / oc-mirror

Lifecycle manager for internet-disconnected OpenShift environments
Apache License 2.0
91 stars 82 forks source link

OCPBUGS-41331: Add an indicator in the log that catalog is mirrored t… #955

Closed sherine-k closed 1 week ago

sherine-k commented 1 week ago

…o cache

Description

This PR adds a simple indicator so that the end user doesn' t think that a catalog image is being mirrored twice during mirror to mirror

Fixes # OCPBUGS-41331

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Verified by mirror to mirror

Expected Outcome

2024/11/19 12:30:19  [INFO]   : images to copy 6 
 ✓ 1/6 : (3s) docker://registry.redhat.io/albo/aws-load-balancer-controller-rhel8@sha256:2e0b9332a44d8d9c23e19c7accab0813a651f39210257820db508cac288…
 ✓ 2/6 : (3s) docker://registry.redhat.io/albo/aws-load-balancer-rhel8-operator@sha256:16e9ffed36107527a37713ac5bd34a7bc20f042269a81077429fb5884914c…
 ✓   3/6 : (7s) docker://registry.redhat.io/openshift4/ose-kube-rbac-proxy@sha256:f11f71448986aa17abec9caadb568a6cc34ef1a7898e6dc20bc6a512830ba476 
 ✓ 4/6 : (3s) docker://registry.redhat.io/albo/aws-load-balancer-operator-bundle@sha256:01f2ca529d2486f113bcefc9fedce6a6fd07bcb48aaf534394b5b04c353f…
 ✓   5/6 : (5s) docker://registry.redhat.io/redhat/redhat-operator-index:v4.15 ► cache 
 ✓   6/6 : (6s) docker://registry.redhat.io/redhat/redhat-operator-index:v4.15
openshift-ci-robot commented 1 week ago

@sherine-k: This pull request references Jira Issue OCPBUGS-41331, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc-mirror/pull/955): >…o cache > ># Description >This PR adds a simple indicator so that the end user doesn' t think that a catalog image is being mirrored twice during mirror to mirror > >Fixes # [OCPBUGS-41331](https://issues.redhat.com/browse/OCPBUGS-41331) > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Verified by mirror to mirror > >## Expected Outcome >``` >2024/11/19 12:01:08 [INFO] : Mirroring is ongoing. No errors. > ✓ 9/17 : (3s) docker://registry.connect.redhat.com/gitlab/gitlab-operator-bundle@sha256:c90d89dbea00a214928ab2671142bd0e9cfc7c01ee816454848d5a7ebcc… > ✓ 10/17 : (13s) docker://registry.redhat.io/redhat/redhat-operator-index:v4.14 ➡️ cache > ✓ 11/17 : (8s) docker://registry.redhat.io/redhat/certified-operator-index:v4.15 ➡️ cache > ✓ 12/17 : (1s) docker://registry.redhat.io/redhat/certified-operator-index:v4.15 > ✓ 13/17 : (0s) docker://registry.redhat.io/redhat/certified-operator-index:v4.16 > ✓ 14/17 : (4s) docker://registry.redhat.io/redhat/certified-operator-index:v4.16 ➡️ cache > ✓ 15/17 : (1s) docker://registry.redhat.io/redhat/redhat-operator-index:v4.14 >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sherine-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/oc-mirror/blob/main/OWNERS)~~ [sherine-k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 week ago

@sherine-k: This pull request references Jira Issue OCPBUGS-41331, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to [this](https://github.com/openshift/oc-mirror/pull/955): >…o cache > ># Description >This PR adds a simple indicator so that the end user doesn' t think that a catalog image is being mirrored twice during mirror to mirror > >Fixes # [OCPBUGS-41331](https://issues.redhat.com/browse/OCPBUGS-41331) > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Verified by mirror to mirror > >## Expected Outcome >``` >2024/11/19 12:30:19 [INFO] : images to copy 6 > ✓ 1/6 : (3s) docker://registry.redhat.io/albo/aws-load-balancer-controller-rhel8@sha256:2e0b9332a44d8d9c23e19c7accab0813a651f39210257820db508cac288… > ✓ 2/6 : (3s) docker://registry.redhat.io/albo/aws-load-balancer-rhel8-operator@sha256:16e9ffed36107527a37713ac5bd34a7bc20f042269a81077429fb5884914c… > ✓ 3/6 : (7s) docker://registry.redhat.io/openshift4/ose-kube-rbac-proxy@sha256:f11f71448986aa17abec9caadb568a6cc34ef1a7898e6dc20bc6a512830ba476 > ✓ 4/6 : (3s) docker://registry.redhat.io/albo/aws-load-balancer-operator-bundle@sha256:01f2ca529d2486f113bcefc9fedce6a6fd07bcb48aaf534394b5b04c353f… > ✓ 5/6 : (5s) docker://registry.redhat.io/redhat/redhat-operator-index:v4.15 ► cache > ✓ 6/6 : (6s) docker://registry.redhat.io/redhat/redhat-operator-index:v4.15 >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lmzuccarelli commented 1 week ago

/lgtm

sherine-k commented 1 week ago

/retest

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 956fc318cc67769aedb2db8c0c4672bf7ed9f909 and 2 for PR HEAD fac147fa34476b1e36af69b445041c12ea6741cf in total

openshift-ci[bot] commented 1 week ago

@sherine-k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 week ago

@sherine-k: Jira Issue OCPBUGS-41331: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41331 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc-mirror/pull/955): >…o cache > ># Description >This PR adds a simple indicator so that the end user doesn' t think that a catalog image is being mirrored twice during mirror to mirror > >Fixes # [OCPBUGS-41331](https://issues.redhat.com/browse/OCPBUGS-41331) > >## Type of change > >Please delete options that are not relevant. > >- [x] Bug fix (non-breaking change which fixes an issue) >- [ ] New feature (non-breaking change which adds functionality) >- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) >- [ ] This change requires a documentation update > ># How Has This Been Tested? > >Verified by mirror to mirror > >## Expected Outcome >``` >2024/11/19 12:30:19 [INFO] : images to copy 6 > ✓ 1/6 : (3s) docker://registry.redhat.io/albo/aws-load-balancer-controller-rhel8@sha256:2e0b9332a44d8d9c23e19c7accab0813a651f39210257820db508cac288… > ✓ 2/6 : (3s) docker://registry.redhat.io/albo/aws-load-balancer-rhel8-operator@sha256:16e9ffed36107527a37713ac5bd34a7bc20f042269a81077429fb5884914c… > ✓ 3/6 : (7s) docker://registry.redhat.io/openshift4/ose-kube-rbac-proxy@sha256:f11f71448986aa17abec9caadb568a6cc34ef1a7898e6dc20bc6a512830ba476 > ✓ 4/6 : (3s) docker://registry.redhat.io/albo/aws-load-balancer-operator-bundle@sha256:01f2ca529d2486f113bcefc9fedce6a6fd07bcb48aaf534394b5b04c353f… > ✓ 5/6 : (5s) docker://registry.redhat.io/redhat/redhat-operator-index:v4.15 ► cache > ✓ 6/6 : (6s) docker://registry.redhat.io/redhat/redhat-operator-index:v4.15 >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc-mirror). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: oc-mirror-plugin This PR has been included in build oc-mirror-plugin-container-v4.19.0-202411192006.p0.gbae91d5.assembly.stream.el9. All builds following this will include this PR.