OCPBUGS-33903: Simplify output when not updating

[petr-muller]

Specific condition details are unlikely to be useful:

$ oc adm upgrade status
The cluster version is not updating (Progressing=False).

  Reason: <none>
  Message: Cluster version is 4.14.1

Sometimes they can get even confusing, especially when the command picks up CVO Failing=True condition present before the update attempt:

$ oc adm upgrade status --details=none
The cluster version is not updating (Progressing=False).

  Reason: MultipleErrors
  Message: Error while reconciling 4.16.0-0.nightly-2024-05-07-025557: an unknown error has occurred: MultipleErrors

I also changed one user-facing occurrence of "upgrade" to "update" as a rider in this PR

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-33903, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @evakhoni

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/oc/pull/1774): >Specific condition details are unlikely to be useful, sometimes they are confusing > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[petr-muller]

I realized previous output could have been useful when the user would be expecting an update but it does not start for some reason: prechecks, download, verification. Maybe it would be useful if we conditionally emited something if spec desired differs from status desired?

[DavidHurta]

I realized previous output could have been useful when the user would be expecting an update but it does not start for some reason: prechecks, download, verification.

That is true.

Maybe it would be useful if we conditionally emited something if spec desired differs from status desired?

I do like the idea of this. We could work on this in the future. If you think implementation-wise this is easy to implement and you are interested in this little improvement, feel free to include it in the PR. Otherwise, we can follow up on this.

[evakhoni]

I realized previous output could have been useful when the user would be expecting an update but it does not start for some reason: prechecks, download, verification.

That is true.

Maybe it would be useful if we conditionally emited something if spec desired differs from status desired?

I do like the idea of this. We could work on this in the future. If you think implementation-wise this is easy to implement and you are interested in this little improvement, feel free to include it in the PR. Otherwise, we can follow up on this.

imo can be a separate card in the future, maybe something a bit more detailed on why do we're unable to start the upgrade, and ideally what can we do about it :thinking:

[openshift-ci-robot]

@petr-muller: This pull request references Jira Issue OCPBUGS-33903, which is valid.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @evakhoni

In response to [this](https://github.com/openshift/oc/pull/1774): >Specific condition details are unlikely to be useful: > >```console >$ oc adm upgrade status >The cluster version is not updating (Progressing=False). > > Reason: > Message: Cluster version is 4.14.1 >``` > >Sometimes they can get even confusing, especially when the command picks up CVO `Failing=True` condition present before the update attempt: > >```console >$ oc adm upgrade status --details=none >The cluster version is not updating (Progressing=False). > > Reason: MultipleErrors > Message: Error while reconciling 4.16.0-0.nightly-2024-05-07-025557: an unknown error has occurred: MultipleErrors >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/cli/admin/upgrade/OWNERS](https://github.com/openshift/oc/blob/master/pkg/cli/admin/upgrade/OWNERS)~~ [petr-muller,wking] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-ci[bot]]

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[openshift-ci-robot]

@petr-muller: Jira Issue OCPBUGS-33903: All pull requests linked via external trackers have merged:

• openshift/oc#1774

Jira Issue OCPBUGS-33903 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/oc/pull/1774): >Specific condition details are unlikely to be useful: > >```console >$ oc adm upgrade status >The cluster version is not updating (Progressing=False). > > Reason: > Message: Cluster version is 4.14.1 >``` > >Sometimes they can get even confusing, especially when the command picks up CVO `Failing=True` condition present before the update attempt: > >```console >$ oc adm upgrade status --details=none >The cluster version is not updating (Progressing=False). > > Reason: MultipleErrors > Message: Error while reconciling 4.16.0-0.nightly-2024-05-07-025557: an unknown error has occurred: MultipleErrors >``` > >I also changed one user-facing occurrence of "upgrade" to "update" as a rider in this PR Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Foc). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[petr-muller]

/cherry-pick release-4.16

[openshift-cherrypick-robot]

@petr-muller: new pull request created: #1781

In response to [this](https://github.com/openshift/oc/pull/1774#issuecomment-2128025238): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-tools-container-v4.17.0-202405240410.p0.g4be3c86.assembly.stream.el9 for distgit ose-tools. All builds following this will include this PR.